Bug 198410

Summary: Web Inspector: Elements: print/rulers/compositing/paint navigation items shouldn't be visible if the inspected target doesn't have a PageAgent
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews211 for win-future none

Description Devin Rousso 2019-05-30 23:55:20 PDT
.
Comment 1 Devin Rousso 2019-05-30 23:56:10 PDT
Created attachment 371041 [details]
Patch
Comment 2 Devin Rousso 2019-05-30 23:57:32 PDT
Comment on attachment 371041 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371041&action=review

> Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:50
>          WI.settings.showShadowDOM.addEventListener(WI.Setting.Event.Changed, this._showShadowDOMSettingChanged, this);

Does ITMLKit have an equivalent concept of "Shadow DOM", or should we be hiding this when `WI.sharedApp.hasExtraDomains`?
Comment 3 EWS Watchlist 2019-05-31 04:00:45 PDT Comment hidden (obsolete)
Comment 4 EWS Watchlist 2019-05-31 04:00:48 PDT Comment hidden (obsolete)
Comment 5 Timothy Hatcher 2019-06-06 16:24:49 PDT
Comment on attachment 371041 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371041&action=review

>> Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:50
>>          WI.settings.showShadowDOM.addEventListener(WI.Setting.Event.Changed, this._showShadowDOMSettingChanged, this);
> 
> Does ITMLKit have an equivalent concept of "Shadow DOM", or should we be hiding this when `WI.sharedApp.hasExtraDomains`?

I don't think they have shadow DOM.
Comment 6 WebKit Commit Bot 2019-06-06 16:28:40 PDT
Comment on attachment 371041 [details]
Patch

Clearing flags on attachment: 371041

Committed r246176: <https://trac.webkit.org/changeset/246176>
Comment 7 WebKit Commit Bot 2019-06-06 16:28:42 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-06-06 16:29:21 PDT
<rdar://problem/51504510>