Summary: | Web Inspector: Elements: print/rulers/compositing/paint navigation items shouldn't be visible if the inspected target doesn't have a PageAgent | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||
Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, timothy, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Devin Rousso
2019-05-30 23:55:20 PDT
Created attachment 371041 [details]
Patch
Comment on attachment 371041 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371041&action=review > Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:50 > WI.settings.showShadowDOM.addEventListener(WI.Setting.Event.Changed, this._showShadowDOMSettingChanged, this); Does ITMLKit have an equivalent concept of "Shadow DOM", or should we be hiding this when `WI.sharedApp.hasExtraDomains`? Comment on attachment 371041 [details] Patch Attachment 371041 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12337845 New failing tests: fast/shadow-dom/svg-thref-href-change-in-shadow-tree.html imported/blink/fast/canvas/canvas-state-persistence-no-dirty.html Created attachment 371049 [details]
Archive of layout-test-results from ews211 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews211 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment on attachment 371041 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371041&action=review >> Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:50 >> WI.settings.showShadowDOM.addEventListener(WI.Setting.Event.Changed, this._showShadowDOMSettingChanged, this); > > Does ITMLKit have an equivalent concept of "Shadow DOM", or should we be hiding this when `WI.sharedApp.hasExtraDomains`? I don't think they have shadow DOM. Comment on attachment 371041 [details] Patch Clearing flags on attachment: 371041 Committed r246176: <https://trac.webkit.org/changeset/246176> All reviewed patches have been landed. Closing bug. |