Bug 198403

Summary: [CMake] Add WebKit::JavaScriptCore target
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: CMakeAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, commit-queue, fujii.hironori, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP Patch
none
Patch none

Don Olmstead
Reported 2019-05-30 18:50:53 PDT
Add Webkit::JavaScriptCore target.
Attachments
WIP Patch (10.03 KB, patch)
2019-05-31 14:39 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (13.30 KB, patch)
2019-05-31 18:34 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2019-05-31 14:39:34 PDT Comment hidden (obsolete)
Don Olmstead
Comment 2 2019-05-31 18:34:03 PDT
Created attachment 371100 [details] Patch
Konstantin Tokarev
Comment 3 2019-05-31 18:46:22 PDT
Comment on attachment 371100 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371100&action=review > Source/JavaScriptCore/CMakeLists.txt:295 > +add_dependencies(LLIntOffsetsExtractor JavaScriptCore_CopyHeaders) Don't we have a dependency cycle here? JavaScriptCore depends on LLIntOffsetsExtractor, JavaScriptCore_CopyHeaders depends on JavaScriptCore, and here LLIntOffsetsExtractor depends on JavaScriptCore_CopyHeaders
Don Olmstead
Comment 4 2019-05-31 18:56:00 PDT
(In reply to Konstantin Tokarev from comment #3) > Comment on attachment 371100 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=371100&action=review > > > Source/JavaScriptCore/CMakeLists.txt:295 > > +add_dependencies(LLIntOffsetsExtractor JavaScriptCore_CopyHeaders) > > Don't we have a dependency cycle here? JavaScriptCore depends on > LLIntOffsetsExtractor, JavaScriptCore_CopyHeaders depends on JavaScriptCore, > and here LLIntOffsetsExtractor depends on JavaScriptCore_CopyHeaders No that’s broken here. The JavaScriptCore_CopyHeaders doesn’t depend on anything.
WebKit Commit Bot
Comment 5 2019-06-03 10:04:41 PDT
Comment on attachment 371100 [details] Patch Clearing flags on attachment: 371100 Committed r246039: <https://trac.webkit.org/changeset/246039>
WebKit Commit Bot
Comment 6 2019-06-03 10:04:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.