Summary: | [CMake] Add WebKit::JavaScriptCore target | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Don Olmstead <don.olmstead> | ||||||
Component: | CMake | Assignee: | Don Olmstead <don.olmstead> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, annulen, commit-queue, Hironori.Fujii, mcatanzaro | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Don Olmstead
2019-05-30 18:50:53 PDT
Created attachment 371086 [details]
WIP Patch
Created attachment 371100 [details]
Patch
Comment on attachment 371100 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371100&action=review > Source/JavaScriptCore/CMakeLists.txt:295 > +add_dependencies(LLIntOffsetsExtractor JavaScriptCore_CopyHeaders) Don't we have a dependency cycle here? JavaScriptCore depends on LLIntOffsetsExtractor, JavaScriptCore_CopyHeaders depends on JavaScriptCore, and here LLIntOffsetsExtractor depends on JavaScriptCore_CopyHeaders (In reply to Konstantin Tokarev from comment #3) > Comment on attachment 371100 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=371100&action=review > > > Source/JavaScriptCore/CMakeLists.txt:295 > > +add_dependencies(LLIntOffsetsExtractor JavaScriptCore_CopyHeaders) > > Don't we have a dependency cycle here? JavaScriptCore depends on > LLIntOffsetsExtractor, JavaScriptCore_CopyHeaders depends on JavaScriptCore, > and here LLIntOffsetsExtractor depends on JavaScriptCore_CopyHeaders No that’s broken here. The JavaScriptCore_CopyHeaders doesn’t depend on anything. Comment on attachment 371100 [details] Patch Clearing flags on attachment: 371100 Committed r246039: <https://trac.webkit.org/changeset/246039> All reviewed patches have been landed. Closing bug. |