Bug 198333

Summary:

Reestablish WebSWClientConnection in case of network process crash

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

Service Workers

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, cdumez, commit-queue, dbates, ews-watchlist, japhet, tsavell, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description youenn fablet 2019-05-29 08:23:04 PDT

Reestablish WebSWClientConnection in case of network process crash

Comment 1 youenn fablet 2019-05-29 09:09:17 PDT

Created attachment 370853 [details]
Patch

Comment 2 WebKit Commit Bot 2019-05-29 15:21:14 PDT

Comment on attachment 370853 [details]
Patch

Clearing flags on attachment: 370853

Committed r245873: <https://trac.webkit.org/changeset/245873>

Comment 3 WebKit Commit Bot 2019-05-29 15:21:16 PDT

All reviewed patches have been landed.  Closing bug.

Comment 4 Radar WebKit Bug Importer 2019-05-29 15:22:14 PDT

<rdar://problem/51239460>

Comment 5 Truitt Savell 2019-05-30 14:51:18 PDT

It looks like the new test http/wpt/service-workers/service-worker-networkprocess-crash.html

Added in https://trac.webkit.org/changeset/245873/webkit

is failing and crashing.

It also appears this patch caused multiple other flakey crashes.
I was able to reproduce the failures on 245873 but not on 245872.

History:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Fwpt%2Fservice-workers%2Fupdate-service-worker.https.html%20http%2Fwpt%2Fservice-workers%2Fuseragent.https.html%20http%2Fwpt%2Fservice-workers%2Fservice-worker-networkprocess-crash.html%20imported%2Fw3c%2Fweb-platform-tests%2FFileAPI%2Fhistorical.https.html%20http%2Fwpt%2Fcache-storage%2Fquota-third-party.https.html%20imported%2Fw3c%2Fweb-platform-tests%2Ffetch%2Fapi%2Fpolicies%2Freferrer-no-referrer-service-worker.https.html%20http%2Fwpt%2Fcrypto%2Faes-cbc-crash.any.worker.html