Bug 198306

Summary: [WHLSL] The name resolver does not deal with nativeFunctionDeclaration
Product: WebKit Reporter: Robin Morisset <rmorisset>
Component: WebGPUAssignee: Robin Morisset <rmorisset>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: commit-queue, mmaxfield, saam, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=198704
Attachments:
Description Flags
Patch for landing
mmaxfield: review-
Patch none

Robin Morisset
Reported 2019-05-28 15:03:18 PDT
...
Attachments
Patch for landing (2.81 KB, patch)
2019-06-05 19:01 PDT, Robin Morisset 		mmaxfield: review-
DetailsFormatted DiffDiff
Patch (3.57 KB, patch)
2019-06-10 12:12 PDT, Robin Morisset 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Robin Morisset
Comment 1 2019-06-05 19:01:44 PDT
Created attachment 371465 [details] Patch for landing
Myles C. Maxfield
Comment 2 2019-06-05 19:12:09 PDT
Comment on attachment 371465 [details] Patch for landing This should be pretty easy to test.
Myles C. Maxfield
Comment 3 2019-06-09 23:43:17 PDT
https://bugs.webkit.org/show_bug.cgi?id=198704 will include a fix for this bug.
Robin Morisset
Comment 4 2019-06-10 12:12:52 PDT
Created attachment 371769 [details] Patch Now with testing.
WebKit Commit Bot
Comment 5 2019-06-17 17:06:22 PDT
Comment on attachment 371769 [details] Patch Clearing flags on attachment: 371769 Committed r246524: <https://trac.webkit.org/changeset/246524>
WebKit Commit Bot
Comment 6 2019-06-17 17:06:24 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-06-17 17:08:28 PDT
<rdar://problem/51828048>
Truitt Savell
Comment 8 2019-06-18 08:58:10 PDT
The changes in https://trac.webkit.org/changeset/246524/webkit has caused 45 WebGPU/ crashes on Mac Debug WK2 only which is why EWS did not catch this. Results: https://build.webkit.org/results/Apple%20Mojave%20Debug%20WK2%20(Tests)/r246525%20(3123)/results.html I was able to reproduce this locally on 246524 but not on 246523
Truitt Savell
Comment 9 2019-06-18 09:44:40 PDT
Reverted r246524 for reason: Caused 45 webgpu/ crashes. Committed r246543: <https://trac.webkit.org/changeset/246543>
Myles C. Maxfield
Comment 10 2019-06-18 19:57:35 PDT
Handled by https://bugs.webkit.org/show_bug.cgi?id=198704 *** This bug has been marked as a duplicate of bug 198704 ***
Note You need to log in before you can comment on or make changes to this bug.