Summary: | Web Inspector: Timelines: spacing around pie chart is different between CPU and Memory | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||||||
Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | commit-queue, hi, inspector-bugzilla-changes, mattbaker, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Attachments: |
|
Description
Devin Rousso
2019-05-28 10:04:36 PDT
Created attachment 370755 [details]
[Image] Screenshot of Issue (CPU)
Created attachment 370756 [details]
[Image] Screenshot of Issue (Memory)
Created attachment 370764 [details]
Patch
Comment on attachment 370764 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370764&action=review r=me with nits > Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.css:97 > + Unnecessary churn. Was this moved on purpose? > Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.js:57 > + case CPUTimelineView.SampleType.JavaScript: Missing namespace prefix `WI`. > Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.js:214 > + this._breakdownLegendScriptElement = appendLegendRow(this._breakdownLegendElement, CPUTimelineView.SampleType.JavaScript); Missing namespace prefix `WI`. > Source/WebInspectorUI/UserInterface/Views/MemoryTimelineView.css:67 > + border-bottom: 1px solid var(--border-color); More churn. Comment on attachment 370764 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370764&action=review >> Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.css:97 >> + > > Unnecessary churn. Was this moved on purpose? I mention the reason for this in the ChangeLog. Although it's "unnecessary", I found it to be an annoyance when first investigating this issue as I had to search around through the file to find the right rule, as it wasn't where I'd expected it to be. >> Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.js:57 >> + case CPUTimelineView.SampleType.JavaScript: > > Missing namespace prefix `WI`. Joe and I have started doing this, but we each have different reasons for it. Either way, the `WI` is not necessary in these cases since they're used within the class object, and the "enum" is defined on that same class object. Joe's reason is to provide "testing" for this "somewhat obscure" part of JSC. My reason is that if we ever decide to move to using modules, this would reduce code churn, as we'd likely drop (or change) the `WI` namespace, as it's probably not as useful with modules. Comment on attachment 370764 [details] Patch Rejecting attachment 370764 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 370764, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=370764&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=198299&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 370764 from bug 198299. Fetching: https://bugs.webkit.org/attachment.cgi?id=370764 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Matt Baker']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 5 diffs from patch file(s). patching file Source/WebInspectorUI/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js Hunk #1 succeeded at 1041 with fuzz 2 (offset 27 lines). patching file Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.css patching file Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.js Hunk #1 FAILED at 54. 1 out of 5 hunks FAILED -- saving rejects to file Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.js.rej patching file Source/WebInspectorUI/UserInterface/Views/MemoryTimelineView.css Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Matt Baker']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/12312120 Created attachment 370803 [details]
Patch
Comment on attachment 370764 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370764&action=review >>> Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.js:57 >>> + case CPUTimelineView.SampleType.JavaScript: >> >> Missing namespace prefix `WI`. > > Joe and I have started doing this, but we each have different reasons for it. Either way, the `WI` is not necessary in these cases since they're used within the class object, and the "enum" is defined on that same class object. > > Joe's reason is to provide "testing" for this "somewhat obscure" part of JSC. > > My reason is that if we ever decide to move to using modules, this would reduce code churn, as we'd likely drop (or change) the `WI` namespace, as it's probably not as useful with modules. Cool, both are good reasons. Comment on attachment 370803 [details] Patch Clearing flags on attachment: 370803 Committed r245833: <https://trac.webkit.org/changeset/245833> All reviewed patches have been landed. Closing bug. |