Bug 198247

Summary: Limit run-benchmark http server to specific interface.
Product: WebKit Reporter: dewei_zhu
Component: Tools / TestsAssignee: dewei_zhu
Status: NEW    
Severity: Normal CC: ap, dewei_zhu, ews-watchlist, glenn, rniwa, slewis
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch rniwa: review+

dewei_zhu
Reported 2019-05-25 03:35:28 PDT
Limit run-benchmark http server to specific interface.
Attachments
Patch (4.55 KB, patch)
2019-05-25 03:40 PDT, dewei_zhu 		no flags
DetailsFormatted DiffDiff
Patch (5.44 KB, patch)
2019-05-27 19:21 PDT, dewei_zhu 		rniwa: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
dewei_zhu
Comment 1 2019-05-25 03:40:24 PDT
Created attachment 370635 [details] Patch
Ryosuke Niwa
Comment 2 2019-05-25 16:15:04 PDT
Comment on attachment 370635 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370635&action=review > Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:58 > + self._server_port = int(re.search('TCP .*:(\d+) \(LISTEN\)', output).group(1)) This will greedily match any text. Is that really intended? Isn't what we want .*? instead?
dewei_zhu
Comment 3 2019-05-25 22:44:13 PDT
Comment on attachment 370635 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370635&action=review >> Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:58 >> + self._server_port = int(re.search('TCP .*:(\d+) \(LISTEN\)', output).group(1)) > > This will greedily match any text. Is that really intended? Isn't what we want .*? instead? The output can be something like: COMMAND PID USER FD TYPE DEVICE SIZE/OFF NODE NAME Python 79032 username 6u IPv6 0x9a7c2ffffffffff 0t0 TCP macbook.local:12345 (LISTEN)
dewei_zhu
Comment 4 2019-05-27 19:21:35 PDT
Created attachment 370711 [details] Patch
Ryosuke Niwa
Comment 5 2019-05-28 14:02:35 PDT
Comment on attachment 370711 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370711&action=review > Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:69 > + self._check_http_server_is_running() We should probably call this _wait_for_http_server or something. Otherwise, it doesn't tell us what it's doing after checking the status.
Note You need to log in before you can comment on or make changes to this bug.