Bug 198215

Summary: Make sure completion handler is always called in SWServer::startSuspension
Product: WebKit Reporter: youenn fablet <youennf>
Component: Service WorkersAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews211 for win-future
none
Patch none

youenn fablet
Reported 2019-05-23 22:34:25 PDT
Make sure completion handler is always called in SWServer::startSuspension
Attachments
Patch (1.58 KB, patch)
2019-05-23 22:37 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews211 for win-future (14.01 MB, application/zip)
2019-05-24 02:32 PDT, EWS Watchlist 		no flags
Details
Patch (3.01 KB, patch)
2019-05-24 15:26 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2019-05-23 22:37:26 PDT
Created attachment 370564 [details] Patch
EWS Watchlist
Comment 2 2019-05-24 02:32:19 PDT
Comment on attachment 370564 [details] Patch Attachment 370564 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12276977 New failing tests: storage/indexeddb/modern/get-keyrange.html css3/filters/blur-various-radii.html
EWS Watchlist
Comment 3 2019-05-24 02:32:21 PDT
Created attachment 370568 [details] Archive of layout-test-results from ews211 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews211 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
youenn fablet
Comment 4 2019-05-24 08:21:21 PDT
Comment on attachment 370564 [details] Patch win error unrelated
WebKit Commit Bot
Comment 5 2019-05-24 11:26:52 PDT
Comment on attachment 370564 [details] Patch Clearing flags on attachment: 370564 Committed r245748: <https://trac.webkit.org/changeset/245748>
WebKit Commit Bot
Comment 6 2019-05-24 11:26:53 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-05-24 11:27:31 PDT
<rdar://problem/51114613>
youenn fablet
Comment 8 2019-05-24 15:26:20 PDT
Reopening to attach new patch.
youenn fablet
Comment 9 2019-05-24 15:26:21 PDT
Created attachment 370594 [details] Patch
youenn fablet
Comment 10 2019-05-24 15:27:14 PDT
Comment on attachment 370594 [details] Patch Wrong bug
Note You need to log in before you can comment on or make changes to this bug.