Bug 198206

Summary:

Use a strongly-typed identifier for pages

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

WebKit2

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, beidson, commit-queue, darin, ews-watchlist, ggaren, rniwa, thorton, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
WIP Patch	ews-watchlist: commit-queue-
Archive of layout-test-results from ews104 for mac-highsierra-wk2	none
WIP Patch	none
WIP Patch	none
WIP Patch	none
WIP Patch	none
WIP Patch	none
WIP Patch	none
WIP Patch	none
WIP Patch	none
WIP Patch	none
WIP Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Chris Dumez

Reported 2019-05-23 18:43:12 PDT

Use a strongly-typed identifier for pages.

Attachments
WIP Patch (606.08 KB, patch) 2019-05-23 18:44 PDT, Chris Dumez	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews104 for mac-highsierra-wk2 (800.64 KB, application/zip) 2019-05-23 19:48 PDT, EWS Watchlist	no flags	Details
WIP Patch (606.08 KB, patch) 2019-05-24 08:50 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
WIP Patch (613.17 KB, patch) 2019-05-24 08:56 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
WIP Patch (597.44 KB, patch) 2019-05-24 09:49 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
WIP Patch (600.90 KB, patch) 2019-05-24 14:16 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
WIP Patch (600.76 KB, patch) 2019-05-24 14:20 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
WIP Patch (600.78 KB, patch) 2019-05-24 14:25 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
WIP Patch (623.80 KB, patch) 2019-05-24 15:47 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
WIP Patch (627.06 KB, patch) 2019-05-24 16:06 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
WIP Patch (635.17 KB, patch) 2019-05-24 16:28 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
WIP Patch (497.29 KB, patch) 2019-05-24 18:08 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (492.53 KB, patch) 2019-05-24 18:42 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (493.64 KB, patch) 2019-05-24 19:02 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (496.43 KB, patch) 2019-05-24 19:22 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (498.73 KB, patch) 2019-05-24 19:51 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (496.21 KB, patch) 2019-05-27 10:29 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (496.41 KB, patch) 2019-05-27 10:34 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (498.64 KB, patch) 2019-05-27 10:52 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (498.64 KB, patch) 2019-05-27 11:57 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (19) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2019-05-23 18:44:03 PDT

Created attachment 370541 [details] WIP Patch

EWS Watchlist

Comment 2 2019-05-23 18:46:46 PDT

Attachment 370541 [details] did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:489: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/page/ChromeClient.h:490: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/loader/EmptyFrameLoaderClient.h:36: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 3 in 180 files If any of these errors are false positives, please file a bug against check-webkit-style.

EWS Watchlist

Comment 3 2019-05-23 19:48:51 PDT

Comment on attachment 370541 [details] WIP Patch Attachment 370541 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12274436 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 4 2019-05-23 19:48:52 PDT

Created attachment 370554 [details] Archive of layout-test-results from ews104 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

Chris Dumez

Comment 5 2019-05-24 08:50:21 PDT

Created attachment 370572 [details] WIP Patch

EWS Watchlist

Comment 6 2019-05-24 08:53:15 PDT

Attachment 370572 [details] did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:489: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/page/ChromeClient.h:490: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/loader/EmptyFrameLoaderClient.h:36: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 3 in 180 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 7 2019-05-24 08:56:39 PDT

Created attachment 370573 [details] WIP Patch

EWS Watchlist

Comment 8 2019-05-24 08:58:58 PDT

Attachment 370573 [details] did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:489: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/page/ChromeClient.h:490: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/loader/EmptyFrameLoaderClient.h:36: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 3 in 183 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 9 2019-05-24 09:49:26 PDT

Created attachment 370576 [details] WIP Patch

EWS Watchlist

Comment 10 2019-05-24 09:51:56 PDT

Attachment 370576 [details] did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:489: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/page/ChromeClient.h:490: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/loader/EmptyFrameLoaderClient.h:36: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 3 in 183 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 11 2019-05-24 14:16:31 PDT

Created attachment 370589 [details] WIP Patch

EWS Watchlist

Comment 12 2019-05-24 14:18:26 PDT

Attachment 370589 [details] did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:489: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/page/ChromeClient.h:490: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/loader/EmptyFrameLoaderClient.h:36: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 3 in 185 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 13 2019-05-24 14:20:41 PDT

Created attachment 370590 [details] WIP Patch

EWS Watchlist

Comment 14 2019-05-24 14:24:08 PDT

Attachment 370590 [details] did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:489: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/page/ChromeClient.h:490: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/loader/EmptyFrameLoaderClient.h:36: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 3 in 185 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 15 2019-05-24 14:25:51 PDT

Created attachment 370592 [details] WIP Patch

EWS Watchlist

Comment 16 2019-05-24 15:05:00 PDT

Attachment 370592 [details] did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:489: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/page/ChromeClient.h:490: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/loader/EmptyFrameLoaderClient.h:36: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 3 in 185 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 17 2019-05-24 15:47:24 PDT

Created attachment 370598 [details] WIP Patch

EWS Watchlist

Comment 18 2019-05-24 15:50:27 PDT

Attachment 370598 [details] did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:489: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/page/ChromeClient.h:490: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/loader/EmptyFrameLoaderClient.h:36: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 3 in 193 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 19 2019-05-24 16:06:20 PDT

Created attachment 370600 [details] WIP Patch

EWS Watchlist

Comment 20 2019-05-24 16:09:30 PDT

Attachment 370600 [details] did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:489: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/page/ChromeClient.h:490: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/loader/EmptyFrameLoaderClient.h:36: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 3 in 194 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 21 2019-05-24 16:28:27 PDT

Created attachment 370604 [details] WIP Patch

EWS Watchlist

Comment 22 2019-05-24 16:31:30 PDT

Attachment 370604 [details] did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:489: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/page/ChromeClient.h:490: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebKit/WebProcess/WebPage/ViewUpdateDispatcher.h:50: The parameter name "pageID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/loader/EmptyFrameLoaderClient.h:36: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 4 in 200 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 23 2019-05-24 18:08:45 PDT

Created attachment 370613 [details] WIP Patch

EWS Watchlist

Comment 24 2019-05-24 18:11:00 PDT

Attachment 370613 [details] did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:489: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/page/ChromeClient.h:490: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebKit/WebProcess/WebPage/ViewUpdateDispatcher.h:51: The parameter name "pageID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/UIProcess/gtk/WaylandCompositor.h:106: The parameter name "pageID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/loader/EmptyFrameLoaderClient.h:36: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 5 in 181 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 25 2019-05-24 18:42:30 PDT

Created attachment 370614 [details] Patch

EWS Watchlist

Comment 26 2019-05-24 18:45:10 PDT

Attachment 370614 [details] did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:489: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/page/ChromeClient.h:490: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/loader/EmptyFrameLoaderClient.h:36: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 3 in 179 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 27 2019-05-24 19:02:13 PDT

Created attachment 370618 [details] Patch

EWS Watchlist

Comment 28 2019-05-24 19:05:46 PDT

Attachment 370618 [details] did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:489: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/page/ChromeClient.h:490: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/loader/EmptyFrameLoaderClient.h:36: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 3 in 179 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 29 2019-05-24 19:22:26 PDT

Created attachment 370619 [details] Patch

EWS Watchlist

Comment 30 2019-05-24 19:25:44 PDT

Attachment 370619 [details] did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:489: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/page/ChromeClient.h:490: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/loader/EmptyFrameLoaderClient.h:36: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 3 in 181 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 31 2019-05-24 19:51:16 PDT

Created attachment 370621 [details] Patch

EWS Watchlist

Comment 32 2019-05-24 19:53:14 PDT

Attachment 370621 [details] did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:489: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/page/ChromeClient.h:490: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/loader/EmptyFrameLoaderClient.h:36: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 3 in 185 files If any of these errors are false positives, please file a bug against check-webkit-style.

EWS Watchlist

Comment 33 2019-05-24 21:36:59 PDT

Comment on attachment 370621 [details] Patch Attachment 370621 [details] did not pass jsc-ews (mac): Output: https://webkit-queues.webkit.org/results/12284995 New failing tests: mozilla-tests.yaml/js1_5/Array/regress-101964.js.mozilla-no-ftl apiTests

youenn fablet

Comment 34 2019-05-26 22:14:42 PDT

Comment on attachment 370621 [details] Patch r=me once bots are happy. View in context: https://bugs.webkit.org/attachment.cgi?id=370621&action=review > Source/WebCore/platform/network/CookieRequestHeaderFieldProxy.h:79 > + result.pageID = WTFMove(*pageID); No real need to move it. > Source/WebCore/platform/network/NetworkStorageSession.h:153 > + WEBCORE_EXPORT void grantStorageAccess(const RegistrableDomain& resourceDomain, const RegistrableDomain& firstPartyDomain, Optional<uint64_t> frameID, PageIdentifier); Might be useful to add a specific FrameIdentifier type as well which I guess would combine a PageIdentifier and a uint64_t. > Source/WebCore/platform/network/curl/CookieJarCurl.cpp:-62 > -void CookieJarCurl::setCookiesFromDOM(const NetworkStorageSession& session, const URL& firstParty, const SameSiteInfo&, const URL& url, Optional<uint64_t> frameID, Optional<uint64_t> pageID, const String& value) const We could remove pageID and remove UNUSED_PARAM(pageID) here and below. > Source/WebKit/NetworkProcess/WebStorage/StorageManager.cpp:497 > +void StorageManager::createSessionStorageNamespace(PageIdentifier storageNamespaceID, unsigned quotaInBytes) A future refactoring should probably move away from PageIdentifier here. If not really needed, I would probably not do these changes.

Chris Dumez

Comment 35 2019-05-27 10:29:23 PDT

Created attachment 370696 [details] Patch

EWS Watchlist

Comment 36 2019-05-27 10:31:12 PDT

Attachment 370696 [details] did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:492: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/page/ChromeClient.h:493: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/loader/EmptyFrameLoaderClient.h:36: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 3 in 184 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 37 2019-05-27 10:34:58 PDT

Created attachment 370697 [details] Patch

EWS Watchlist

Comment 38 2019-05-27 10:36:54 PDT

Attachment 370697 [details] did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:492: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/page/ChromeClient.h:493: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/loader/EmptyFrameLoaderClient.h:36: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 3 in 184 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 39 2019-05-27 10:52:28 PDT

Created attachment 370698 [details] Patch

EWS Watchlist

Comment 40 2019-05-27 10:55:49 PDT

Attachment 370698 [details] did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:492: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/page/ChromeClient.h:493: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/loader/EmptyFrameLoaderClient.h:36: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 3 in 186 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 41 2019-05-27 11:57:24 PDT

Created attachment 370701 [details] Patch

EWS Watchlist

Comment 42 2019-05-27 11:59:33 PDT

Attachment 370701 [details] did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:492: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/page/ChromeClient.h:493: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/loader/EmptyFrameLoaderClient.h:36: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 3 in 186 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 43 2019-05-27 13:31:00 PDT

Comment on attachment 370701 [details] Patch Clearing flags on attachment: 370701 Committed r245796: <https://trac.webkit.org/changeset/245796>

WebKit Commit Bot

Comment 44 2019-05-27 13:31:02 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 45 2019-05-27 13:31:26 PDT

<rdar://problem/51163156>

Note You need to log in before you can comment on or make changes to this bug.