Bug 198196

Summary: [WHLSL] Don't wrap anonymous variables in parens in the AST dumper
Product: WebKit Reporter: Saam Barati <saam>
Component: WebGPUAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, jonlee, justin_fan, mmaxfield, rmorisset, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Saam Barati
Reported 2019-05-23 14:49:11 PDT
Makes things easier to read IMO
Attachments
patch (1.79 KB, patch)
2019-05-23 15:00 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2019-05-23 14:52:47 PDT
foo.bar.x = 42; Goes from ($(0x7f86d9d94440) = &foo, $(0x7f86d9d944e0) = operator.bar(*$(0x7f86d9d94440)), $(0x7f86d9d944e0) = operator.x=($(0x7f86d9d944e0), 42), *$(0x7f86d9d94440) = operator.bar=(*$(0x7f86d9d94440), $(0x7f86d9d944e0))); to: ($0x7f86d9d94440 = &foo, $0x7f86d9d944e0 = operator.bar(*$0x7f86d9d94440), $0x7f86d9d944e0 = operator.x=($0x7f86d9d944e0, 42), *$0x7f86d9d94440 = operator.bar=(*$0x7f86d9d94440, $0x7f86d9d944e0));
Saam Barati
Comment 2 2019-05-23 15:00:54 PDT
Created attachment 370523 [details] patch
WebKit Commit Bot
Comment 3 2019-05-23 16:13:51 PDT
Comment on attachment 370523 [details] patch Clearing flags on attachment: 370523 Committed r245724: <https://trac.webkit.org/changeset/245724>
WebKit Commit Bot
Comment 4 2019-05-23 16:13:52 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2019-05-23 16:14:20 PDT
<rdar://problem/51086976>
Note You need to log in before you can comment on or make changes to this bug.