Summary: | createListFromArrayLike should throw if value is not an object | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tadeu Zagallo <tzagallo> | ||||||||
Component: | JavaScriptCore | Assignee: | Tadeu Zagallo <tzagallo> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, ews-watchlist, guijemont, guijemont+jsc-armv7-ews, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer, ysuzuki | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Tadeu Zagallo
2019-05-22 13:44:40 PDT
Created attachment 370440 [details]
Patch
Comment on attachment 370440 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370440&action=review > Source/JavaScriptCore/runtime/JSObjectInlines.h:42 > + throwTypeError(exec, scope, errorMessage); Can we throw an error with the other error message like "ArrayLike is not an object"_s? `createListFromArrayLike`'s caller passes the errorMessage related to Symbol / String. Created attachment 370448 [details]
Patch
Comment on attachment 370448 [details] Patch Attachment 370448 [details] did not pass jsc-ews (mac): Output: https://webkit-queues.webkit.org/results/12262203 New failing tests: stress/proxy-get-own-property-names-should-not-clear-previous-results.js.ftl-no-cjit-no-inline-validate stress/proxy-get-own-property-names-should-not-clear-previous-results.js.dfg-eager-no-cjit-validate stress/proxy-get-own-property-names-should-not-clear-previous-results.js.no-cjit-validate-phases stress/proxy-get-own-property-names-should-not-clear-previous-results.js.dfg-eager stress/proxy-get-own-property-names-should-not-clear-previous-results.js.ftl-eager stress/proxy-get-own-property-names-should-not-clear-previous-results.js.ftl-no-cjit-b3o0 stress/proxy-get-own-property-names-should-not-clear-previous-results.js.ftl-eager-no-cjit-b3o1 stress/proxy-get-own-property-names-should-not-clear-previous-results.js.no-cjit-collect-continuously stress/proxy-get-own-property-names-should-not-clear-previous-results.js.ftl-no-cjit-small-pool stress/proxy-get-own-property-names-should-not-clear-previous-results.js.ftl-no-cjit-no-put-stack-validate stress/proxy-get-own-property-names-should-not-clear-previous-results.js.no-llint stress/proxy-get-own-property-names-should-not-clear-previous-results.js.ftl-no-cjit-validate-sampling-profiler stress/proxy-get-own-property-names-should-not-clear-previous-results.js.default stress/proxy-get-own-property-names-should-not-clear-previous-results.js.no-ftl stress/proxy-get-own-property-names-should-not-clear-previous-results.js.ftl-eager-no-cjit stress/proxy-get-own-property-names-should-not-clear-previous-results.js.bytecode-cache stress/proxy-get-own-property-names-should-not-clear-previous-results.js.dfg-maximal-flush-validate-no-cjit apiTests Comment on attachment 370448 [details] Patch Attachment 370448 [details] did not pass jsc-armv7-ews (jsc-only): Output: https://webkit-queues.webkit.org/results/12263232 New failing tests: stress/proxy-get-own-property-names-should-not-clear-previous-results.js.dfg-eager-no-cjit-validate stress/proxy-get-own-property-names-should-not-clear-previous-results.js.no-cjit-validate-phases stress/proxy-get-own-property-names-should-not-clear-previous-results.js.dfg-eager stress/proxy-get-own-property-names-should-not-clear-previous-results.js.no-cjit-collect-continuously stress/proxy-get-own-property-names-should-not-clear-previous-results.js.default stress/proxy-get-own-property-names-should-not-clear-previous-results.js.no-llint stress/proxy-get-own-property-names-should-not-clear-previous-results.js.dfg-maximal-flush-validate-no-cjit apiTests Created attachment 370492 [details]
Patch for landing
Comment on attachment 370492 [details] Patch for landing Clearing flags on attachment: 370492 Committed r245675: <https://trac.webkit.org/changeset/245675> All reviewed patches have been landed. Closing bug. |