Bug 198049

Summary: Remove outdated FIXME in StorageManager
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: New BugsAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Sihui Liu
Reported 2019-05-20 11:57:38 PDT
Fix the FIXMEs in StorageManager
Attachments
Patch (5.14 KB, patch)
2019-05-24 14:37 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.39 KB, patch)
2019-05-31 20:33 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sihui Liu
Comment 1 2019-05-24 14:36:04 PDT
After r245649, we start dispatching StorageManager messages to main thread of network process and actually handling them on background thread. Therefore the places we marked that need message check won't be checked until after message dispatching completes on main thread.
Sihui Liu
Comment 2 2019-05-24 14:37:47 PDT
Created attachment 370593 [details] Patch
Geoffrey Garen
Comment 3 2019-05-24 16:04:15 PDT
Comment on attachment 370593 [details] Patch r=me
Sihui Liu
Comment 4 2019-05-31 20:33:17 PDT
Created attachment 371106 [details] Patch for landing
WebKit Commit Bot
Comment 5 2019-05-31 21:16:46 PDT
Comment on attachment 371106 [details] Patch for landing Clearing flags on attachment: 371106 Committed r246011: <https://trac.webkit.org/changeset/246011>
WebKit Commit Bot
Comment 6 2019-05-31 21:16:47 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-05-31 21:17:19 PDT
<rdar://problem/51325006>
Note You need to log in before you can comment on or make changes to this bug.