Web Inspector: Sources: gear icons moves to 2nd line when sidebar is narrow

• Component: Web Inspector
• Status: RESOLVED FIXED

[Nikita Vasilyev]

Created attachment 370200 [details]
[Image] Bug

The gear icon should stay on the same line — it shouldn't wrap.

[Jamal Nasser]

Removing the flex-wrap property from .navigation-bar and .navigation-bar .item in NavigationBar.css fixes this, but I'm guessing those are in there serving another purpose and removing them may not be the best idea...

https://i.imgur.com/8bWGoEB.png

[Devin Rousso]

Created attachment 376347 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 376347 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376347&action=review

r=me

> Source/WebInspectorUI/ChangeLog:54
> +
> +

Nit: too many lines

> Source/WebInspectorUI/UserInterface/Views/TextNavigationItem.js:40
>      // Public
>  
> +    get totalMargin()

Shouldn't this be in some Protected region?

[Devin Rousso]

Comment on attachment 376347 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376347&action=review

>> Source/WebInspectorUI/ChangeLog:54
>> +
> 
> Nit: too many lines

Oops :P

>> Source/WebInspectorUI/UserInterface/Views/TextNavigationItem.js:40
>> +    get totalMargin()
> 
> Shouldn't this be in some Protected region?

Yes, it should be.  I'd originally intended this to be `static`, but due to `WI.ButtonNavigationItem.Style` it ended up being a member variable.  I'll move it.

[Devin Rousso]

Created attachment 376597 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 376597 [details]
Patch

Clearing flags on attachment: 376597

Committed r248818: <https://trac.webkit.org/changeset/248818>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/54422378>