Bug 198017

Summary: Web Inspector: Sources: gear icons moves to 2nd line when sidebar is narrow
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, jamaln, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Image] Bug
none
Patch
none
Patch none

Nikita Vasilyev
Reported 2019-05-18 16:04:47 PDT
Created attachment 370200 [details] [Image] Bug The gear icon should stay on the same line — it shouldn't wrap.
Attachments
[Image] Bug (70.61 KB, image/png)
2019-05-18 16:04 PDT, Nikita Vasilyev 		no flags
Details
Patch (20.19 KB, patch)
2019-08-14 20:39 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (20.42 KB, patch)
2019-08-17 00:29 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jamal Nasser
Comment 1 2019-06-05 08:31:40 PDT
Removing the flex-wrap property from .navigation-bar and .navigation-bar .item in NavigationBar.css fixes this, but I'm guessing those are in there serving another purpose and removing them may not be the best idea... https://i.imgur.com/8bWGoEB.png
Devin Rousso
Comment 2 2019-08-14 20:39:41 PDT
Created attachment 376347 [details] Patch
Joseph Pecoraro
Comment 3 2019-08-16 20:19:16 PDT
Comment on attachment 376347 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376347&action=review r=me > Source/WebInspectorUI/ChangeLog:54 > + > + Nit: too many lines > Source/WebInspectorUI/UserInterface/Views/TextNavigationItem.js:40 > // Public > > + get totalMargin() Shouldn't this be in some Protected region?
Devin Rousso
Comment 4 2019-08-16 22:56:49 PDT
Comment on attachment 376347 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376347&action=review >> Source/WebInspectorUI/ChangeLog:54 >> + > > Nit: too many lines Oops :P >> Source/WebInspectorUI/UserInterface/Views/TextNavigationItem.js:40 >> + get totalMargin() > > Shouldn't this be in some Protected region? Yes, it should be. I'd originally intended this to be `static`, but due to `WI.ButtonNavigationItem.Style` it ended up being a member variable. I'll move it.
Devin Rousso
Comment 5 2019-08-17 00:29:05 PDT
Created attachment 376597 [details] Patch
WebKit Commit Bot
Comment 6 2019-08-17 01:11:37 PDT
Comment on attachment 376597 [details] Patch Clearing flags on attachment: 376597 Committed r248818: <https://trac.webkit.org/changeset/248818>
WebKit Commit Bot
Comment 7 2019-08-17 01:11:38 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-08-17 01:12:16 PDT
<rdar://problem/54422378>
Note You need to log in before you can comment on or make changes to this bug.