Bug 198010

Summary:

[Mac] Add API test to make sure the system font is drawn just like in native code

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

New Bugs

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, ews-watchlist, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	dbates: review+
Patch for committing	none
Patch for committing	ews-watchlist: commit-queue-
Archive of layout-test-results from ews211 for win-future	none

Myles C. Maxfield

Reported 2019-05-17 18:21:25 PDT

[Mac] Add API test to make sure the system font is drawn just like in native code

Attachments
Patch (9.78 KB, patch) 2019-05-17 18:22 PDT, Myles C. Maxfield	dbates: review+	Details Formatted Diff Diff
Patch for committing (10.07 KB, patch) 2019-05-21 17:10 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch for committing (11.24 KB, patch) 2019-05-22 10:09 PDT, Myles C. Maxfield	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews211 for win-future (14.22 MB, application/zip) 2019-05-22 13:15 PDT, EWS Watchlist	no flags	Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Myles C. Maxfield

Comment 1 2019-05-17 18:22:29 PDT

Created attachment 370174 [details] Patch

Daniel Bates

Comment 2 2019-05-17 20:33:26 PDT

Comment on attachment 370174 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370174&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/TextWidth.html:2 > +<html lang="en-US"> Ok as is. Lang attribute doesn't seem required. > Tools/TestWebKitAPI/Tests/WebKitCocoa/TextWidth.mm:35 > + RetainPtr<WKWebViewConfiguration> configuration = adoptNS([[WKWebViewConfiguration alloc] init]); Auto? > Tools/TestWebKitAPI/Tests/WebKitCocoa/TextWidth.mm:36 > + RetainPtr<WKWebView> webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600) configuration:configuration.get()]); Auto? > Tools/TestWebKitAPI/Tests/WebKitCocoa/TextWidth.mm:50 > + NSAttributedString *attributedString = [[NSAttributedString alloc] initWithString:@"This is a test string" attributes:@{NSFontAttributeName : static_cast<NSFont *>(font.get())}]; Looks like a leak. If not, better idiom in my opinion is use retainPtr and call .leak() at the call site <---- makes grepping easy . Grep code for examples.

Myles C. Maxfield

Comment 3 2019-05-21 17:10:19 PDT

Created attachment 370359 [details] Patch for committing

Myles C. Maxfield

Comment 4 2019-05-22 10:09:41 PDT

Created attachment 370414 [details] Patch for committing

EWS Watchlist

Comment 5 2019-05-22 13:15:00 PDT

Comment on attachment 370414 [details] Patch for committing Attachment 370414 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12259985 New failing tests: fast/shadow-dom/svg-use-href-change-in-shadow-tree.html imported/blink/fast/canvas/bug382588.html

EWS Watchlist

Comment 6 2019-05-22 13:15:23 PDT

Created attachment 370438 [details] Archive of layout-test-results from ews211 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews211 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

Myles C. Maxfield

Comment 7 2019-05-22 21:12:51 PDT

Committed r245671: <https://trac.webkit.org/changeset/245671>

Radar WebKit Bug Importer

Comment 8 2019-05-22 21:13:24 PDT

<rdar://problem/51054624>

Note You need to log in before you can comment on or make changes to this bug.