Bug 197984

Summary: [GTK] Use a repeating timer to populate emoji chooser
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, bugs-noreply, ews-watchlist, gustavo, mcatanzaro
Priority: P2 Keywords: Gtk
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=176760
Attachments:
Description Flags
Patch mcatanzaro: review+

Carlos Garcia Campos
Reported 2019-05-17 08:10:42 PDT
That's what gtk4 does too. It ensures the emoji chooser popover is shown as soon as it's requested.
Attachments
Patch (10.83 KB, patch)
2019-05-17 08:13 PDT, Carlos Garcia Campos 		mcatanzaro: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2019-05-17 08:13:28 PDT
Created attachment 370117 [details] Patch
EWS Watchlist
Comment 2 2019-05-17 08:14:58 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Michael Catanzaro
Comment 3 2019-05-17 10:03:58 PDT
Comment on attachment 370117 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370117&action=review > Source/WebKit/UIProcess/API/gtk/WebKitEmojiChooser.cpp:524 > + chooser->priv->populateSectionsTimer->setName("[WebKitEmojiChooser] populate sections timer"); Thank you for naming your timer!
Carlos Garcia Campos
Comment 4 2019-05-20 01:15:33 PDT
Committed r245513: <https://trac.webkit.org/changeset/245513>
Note You need to log in before you can comment on or make changes to this bug.