Bug 197984

Summary: [GTK] Use a repeating timer to populate emoji chooser
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, bugs-noreply, ews-watchlist, gustavo, mcatanzaro
Priority: P2 Keywords: Gtk
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=176760
Attachments:
Description Flags
Patch mcatanzaro: review+

Description Carlos Garcia Campos 2019-05-17 08:10:42 PDT
That's what gtk4 does too. It ensures the emoji chooser popover is shown as soon as it's requested.
Comment 1 Carlos Garcia Campos 2019-05-17 08:13:28 PDT
Created attachment 370117 [details]
Patch
Comment 2 EWS Watchlist 2019-05-17 08:14:58 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Michael Catanzaro 2019-05-17 10:03:58 PDT
Comment on attachment 370117 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370117&action=review

> Source/WebKit/UIProcess/API/gtk/WebKitEmojiChooser.cpp:524
> +    chooser->priv->populateSectionsTimer->setName("[WebKitEmojiChooser] populate sections timer");

Thank you for naming your timer!
Comment 4 Carlos Garcia Campos 2019-05-20 01:15:33 PDT
Committed r245513: <https://trac.webkit.org/changeset/245513>