Summary: | [GTK] Use a repeating timer to populate emoji chooser | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | berto, bugs-noreply, ews-watchlist, gustavo, mcatanzaro | ||||
Priority: | P2 | Keywords: | Gtk | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=176760 | ||||||
Attachments: |
|
Description
Carlos Garcia Campos
2019-05-17 08:10:42 PDT
Created attachment 370117 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 370117 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370117&action=review > Source/WebKit/UIProcess/API/gtk/WebKitEmojiChooser.cpp:524 > + chooser->priv->populateSectionsTimer->setName("[WebKitEmojiChooser] populate sections timer"); Thank you for naming your timer! Committed r245513: <https://trac.webkit.org/changeset/245513> |