Bug 197968

Summary: REGRESSION (r15133): Fix leak of JSStringRef in minidom
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Tools / TestsAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, ggaren, joepeck, keith_miller, mark.lam, msaboff, sbarati, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch v1 none

Description David Kilzer (:ddkilzer) 2019-05-16 16:01:14 PDT
Fix leak of JSStringRef in minidom.

This regressed with the original commit back on July 1, 2006 in r15133 (nearly 13 years ago).

<https://trac.webkit.org/r15133>

Found by searching for incorrect uses of JSValueToStringCopy() that weren't calling JSStringRelease() or weren't adopting the result into a JSRetainPtr<JSStringRef> container.
Comment 1 Radar WebKit Bug Importer 2019-05-16 16:01:36 PDT
<rdar://problem/50872430>
Comment 2 David Kilzer (:ddkilzer) 2019-05-16 16:30:25 PDT
Created attachment 370088 [details]
Patch v1
Comment 3 Joseph Pecoraro 2019-05-16 17:51:15 PDT
Comment on attachment 370088 [details]
Patch v1

r=me
Comment 4 WebKit Commit Bot 2019-05-16 18:17:53 PDT
Comment on attachment 370088 [details]
Patch v1

Clearing flags on attachment: 370088

Committed r245430: <https://trac.webkit.org/changeset/245430>
Comment 5 WebKit Commit Bot 2019-05-16 18:17:55 PDT
All reviewed patches have been landed.  Closing bug.