Bug 197952

Summary: Layout Test http/wpt/cache-storage/cache-quota-add.any.html is a flaky failure
Product: WebKit Reporter: Shawn Roberts <sroberts>
Component: Tools / TestsAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, jlewis3, ryanhaddad, tsavell, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Shawn Roberts 2019-05-16 10:54:01 PDT
The following layout test is failing on iOS Simulator Release

http/wpt/cache-storage/cache-quota-add.any.html

Probable cause:

Test was added in https://trac.webkit.org/changeset/244918/webkit and is a very consistent failure on iOS Simulator Release.

Test is failing, but is a harness timeout

I cannot reproduce it locally. I have tried the test by itself with 5000 iterations multiple times. I have tried it in Guard malloc and Asan and still cannot replicate.
I have run it with the worker list from run #4135 and cannot get it to fail running that test list, even with 25 iterations. Test list from https://build.webkit.org/builders/Apple%20iOS%2012%20Simulator%20Release%20WK2%20%28Tests%29/builds/4135

Will add additional configuration attempts to reproduce in the Radar.

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Fwpt%2Fcache-storage%2Fcache-quota-add.any.html

Diff:

--- /Volumes/Data/slave/ios-simulator-12-release-tests-wk2/build/layout-test-results/http/wpt/cache-storage/cache-quota-add.any-expected.txt
+++ /Volumes/Data/slave/ios-simulator-12-release-tests-wk2/build/layout-test-results/http/wpt/cache-storage/cache-quota-add.any-actual.txt
@@ -1,6 +1,6 @@
-CONSOLE MESSAGE: Cache API operation failed: Quota exceeded
-CONSOLE MESSAGE: Cache API operation failed: Quota exceeded
 
-PASS Testing that cache.add checks against quota 
-PASS Testing that cache.addAll checks against quota 
+Harness Error (TIMEOUT), message = null
 
+TIMEOUT Testing that cache.add checks against quota Test timed out
+NOTRUN Testing that cache.addAll checks against quota 
+
Comment 1 Radar WebKit Bug Importer 2019-05-16 10:54:40 PDT
<rdar://problem/50859168>
Comment 2 youenn fablet 2019-05-16 11:01:02 PDT
Created attachment 370049 [details]
Patch
Comment 3 WebKit Commit Bot 2019-05-16 11:31:29 PDT
Comment on attachment 370049 [details]
Patch

Clearing flags on attachment: 370049

Committed r245402: <https://trac.webkit.org/changeset/245402>
Comment 4 WebKit Commit Bot 2019-05-16 11:31:30 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Shawn Roberts 2019-05-17 10:39:28 PDT
After changes in https://trac.webkit.org/changeset/245402 , it looks like the added slow flag worked on iOS. 

Test is failing with a harness timeout error, but the Diff is slightly different.

Still cannot reproduce locally.

Youenn do I just need to mark it slow there as well? Or did something else regress this?

Diff:

--- /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/http/wpt/cache-storage/cache-quota-add.any-expected.txt
+++ /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/http/wpt/cache-storage/cache-quota-add.any-actual.txt
@@ -1,6 +1,7 @@
-CONSOLE MESSAGE: Cache API operation failed: Quota exceeded
 CONSOLE MESSAGE: Cache API operation failed: Quota exceeded
 
+Harness Error (TIMEOUT), message = null
+
 PASS Testing that cache.add checks against quota 
-PASS Testing that cache.addAll checks against quota 
+TIMEOUT Testing that cache.addAll checks against quota Test timed out
Comment 6 Shawn Roberts 2019-05-17 10:42:10 PDT
New Failure is on Mojave Release and Debug
Comment 7 youenn fablet 2019-05-17 10:55:48 PDT
(In reply to Shawn Roberts from comment #6)
> New Failure is on Mojave Release and Debug

It seems there is a regression, not only this test is affected.
Comment 8 youenn fablet 2019-05-31 09:39:48 PDT
Flakiness dashboard is good now.