Summary: | Layout Test http/wpt/cache-storage/cache-quota-add.any.html is a flaky failure | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Shawn Roberts <sroberts> | ||||
Component: | Tools / Tests | Assignee: | youenn fablet <youennf> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cdumez, commit-queue, jlewis3, ryanhaddad, tsavell, webkit-bug-importer, youennf | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Shawn Roberts
2019-05-16 10:54:01 PDT
Created attachment 370049 [details]
Patch
Comment on attachment 370049 [details] Patch Clearing flags on attachment: 370049 Committed r245402: <https://trac.webkit.org/changeset/245402> All reviewed patches have been landed. Closing bug. After changes in https://trac.webkit.org/changeset/245402 , it looks like the added slow flag worked on iOS. Test is failing with a harness timeout error, but the Diff is slightly different. Still cannot reproduce locally. Youenn do I just need to mark it slow there as well? Or did something else regress this? Diff: --- /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/http/wpt/cache-storage/cache-quota-add.any-expected.txt +++ /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/http/wpt/cache-storage/cache-quota-add.any-actual.txt @@ -1,6 +1,7 @@ -CONSOLE MESSAGE: Cache API operation failed: Quota exceeded CONSOLE MESSAGE: Cache API operation failed: Quota exceeded +Harness Error (TIMEOUT), message = null + PASS Testing that cache.add checks against quota -PASS Testing that cache.addAll checks against quota +TIMEOUT Testing that cache.addAll checks against quota Test timed out New Failure is on Mojave Release and Debug (In reply to Shawn Roberts from comment #6) > New Failure is on Mojave Release and Debug It seems there is a regression, not only this test is affected. Flakiness dashboard is good now. |