Summary: | [iOS] Select all with existing range selection replaces range instead of selecting all text | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||||
Component: | WebKit Misc. | Assignee: | Daniel Bates <dbates> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | megan_gardner, webkit-bug-importer, wenson_hsieh | ||||||
Priority: | P2 | Keywords: | InRadar, PlatformOnly | ||||||
Version: | WebKit Local Build | ||||||||
Hardware: | iPhone / iPad | ||||||||
OS: | iOS 12 | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 190571 | ||||||||
Attachments: |
|
Description
Daniel Bates
2019-05-16 10:13:23 PDT
Created attachment 370048 [details]
Patch and layout test
Comment on attachment 370048 [details] Patch and layout test View in context: https://bugs.webkit.org/attachment.cgi?id=370048&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3000 > + return !editorState.selectionIsNone && self.hasContent; This might also mean that the callout bar when there's a ranged selection will now contain "Select All", but I don't think that is necessarily a bad thing :) (In reply to Wenson Hsieh from comment #3) > Comment on attachment 370048 [details] > Patch and layout test > > View in context: > https://bugs.webkit.org/attachment.cgi?id=370048&action=review > > > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3000 > > + return !editorState.selectionIsNone && self.hasContent; > > This might also mean that the callout bar when there's a ranged selection > will now contain "Select All", but I don't think that is necessarily a bad > thing :) It's a nice feature, but it doesn't match platform conventions. So, I'll need to fix up the patch before landing to keep differentiate between when the keyboard is asking and when the callout bar is asking to give different answers. Looks like I'll need to make a UIKit change to be able to know who called canPerformAction (In reply to Daniel Bates from comment #5) > Looks like I'll need to make a UIKit change to be able to know who called > canPerformAction No UIKit change necessary callout bar calls -canPerformAction with sender UIMenuController. Created attachment 373063 [details]
To land
Do what we do now if -canPerformAction is called by the callout menu code
Comment on attachment 373063 [details] To land Clearing flags on attachment: 373063 Committed r246908: <https://trac.webkit.org/changeset/246908> All reviewed patches have been landed. Closing bug. |