Bug 197929

Summary:

Update the CSS Text WPT test suite

Product:

WebKit

Reporter:

Javier Fernandez <jfernandez>

Component:

Text

Assignee:

Javier Fernandez <jfernandez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, jfernandez, mmaxfield, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Safari Technology Preview

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews102 for mac-highsierra	none
Archive of layout-test-results from ews104 for mac-highsierra-wk2	none
Archive of layout-test-results from ews116 for mac-highsierra	none
Archive of layout-test-results from ews126 for ios-simulator-wk2	none
Patch	none

Javier Fernandez

Reported 2019-05-15 15:25:48 PDT

Update the CSS Text test suite.

Attachments
Patch (58.78 KB, patch) 2019-05-15 15:33 PDT, Javier Fernandez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-highsierra (3.09 MB, application/zip) 2019-05-15 16:37 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews104 for mac-highsierra-wk2 (2.68 MB, application/zip) 2019-05-15 16:50 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews116 for mac-highsierra (2.96 MB, application/zip) 2019-05-15 17:19 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (8.06 MB, application/zip) 2019-05-15 17:34 PDT, EWS Watchlist	no flags	Details
Patch (63.04 KB, patch) 2019-06-04 14:30 PDT, Javier Fernandez	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Javier Fernandez

Comment 1 2019-05-15 15:33:33 PDT

Created attachment 369997 [details] Patch

EWS Watchlist

Comment 2 2019-05-15 16:37:12 PDT

Comment on attachment 369997 [details] Patch Attachment 369997 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12202073 New failing tests: imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-010.html

EWS Watchlist

Comment 3 2019-05-15 16:37:14 PDT

Created attachment 370007 [details] Archive of layout-test-results from ews102 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 4 2019-05-15 16:50:52 PDT

Comment on attachment 369997 [details] Patch Attachment 369997 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12202150 New failing tests: imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-010.html

EWS Watchlist

Comment 5 2019-05-15 16:50:54 PDT

Created attachment 370008 [details] Archive of layout-test-results from ews104 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 6 2019-05-15 17:19:19 PDT

Comment on attachment 369997 [details] Patch Attachment 369997 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12202201 New failing tests: imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-010.html

EWS Watchlist

Comment 7 2019-05-15 17:19:21 PDT

Created attachment 370009 [details] Archive of layout-test-results from ews116 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 8 2019-05-15 17:34:30 PDT

Comment on attachment 369997 [details] Patch Attachment 369997 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12202278 New failing tests: imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-010.html

EWS Watchlist

Comment 9 2019-05-15 17:34:32 PDT

Created attachment 370010 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.4

Javier Fernandez

Comment 10 2019-05-16 06:46:57 PDT

Comment on attachment 369997 [details] Patch It seems there is a bug in the break-spaces implementation for the SimpleLineLayout codepath. Cancelled review request until I can investigate the issue and file the corresponding bug report.

Javier Fernandez

Comment 11 2019-06-04 14:30:43 PDT

Created attachment 371337 [details] Patch

WebKit Commit Bot

Comment 12 2019-06-05 06:22:59 PDT

Comment on attachment 371337 [details] Patch Clearing flags on attachment: 371337 Committed r246104: <https://trac.webkit.org/changeset/246104>

WebKit Commit Bot

Comment 13 2019-06-05 06:23:01 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 14 2019-06-05 06:23:19 PDT

<rdar://problem/51438402>

Note You need to log in before you can comment on or make changes to this bug.