Bug 197924

Summary: Revise sandbox to allow IOKit properties needed by Metal and LaunchServices
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, eric.carlson, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch pvollan: review+

Description Brent Fulgham 2019-05-15 13:28:35 PDT
Review of test logs have shown the following sandbox violations that could result in reduced performance or slower launch times:

  Sandbox: com.apple.WebKit() deny(1) iokit-get-properties od-server-name
  Sandbox: com.apple.WebKit() deny(1) iokit-get-properties image-path
  Sandbox: com.apple.WebKit() deny(1) iokit-get-properties filevault-image
  Sandbox: com.apple.WebKit() deny(1) iokit-get-properties ATY,FamilyName
  Sandbox: com.apple.WebKit() deny(1) iokit-get-properties ATY,DeviceName

We should allow these accesses.
Comment 1 Radar WebKit Bug Importer 2019-05-15 13:29:17 PDT
<rdar://problem/50823976>
Comment 2 Brent Fulgham 2019-05-15 13:30:36 PDT
Created attachment 369988 [details]
Patch
Comment 3 Per Arne Vollan 2019-05-15 13:40:10 PDT
Comment on attachment 369988 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369988&action=review

Looks good! R=me.

> Source/WebKit/ChangeLog:5
> +        Revise sandbox to allow IOKit properties needed by Metal and LaunchServices
> +        https://bugs.webkit.org/show_bug.cgi?id=197924
> +

Do we have a Radar?
Comment 4 Brent Fulgham 2019-05-15 15:27:26 PDT
Committed r245360: <https://trac.webkit.org/changeset/245360>