Bug 197924

Summary:

Revise sandbox to allow IOKit properties needed by Metal and LaunchServices

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

WebKit Misc.

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, bfulgham, eric.carlson, pvollan, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	pvollan: review+

Brent Fulgham

Reported 2019-05-15 13:28:35 PDT

Review of test logs have shown the following sandbox violations that could result in reduced performance or slower launch times: Sandbox: com.apple.WebKit() deny(1) iokit-get-properties od-server-name Sandbox: com.apple.WebKit() deny(1) iokit-get-properties image-path Sandbox: com.apple.WebKit() deny(1) iokit-get-properties filevault-image Sandbox: com.apple.WebKit() deny(1) iokit-get-properties ATY,FamilyName Sandbox: com.apple.WebKit() deny(1) iokit-get-properties ATY,DeviceName We should allow these accesses.

Attachments
Patch (2.60 KB, patch) 2019-05-15 13:30 PDT, Brent Fulgham	pvollan: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2019-05-15 13:29:17 PDT

<rdar://problem/50823976>

Brent Fulgham

Comment 2 2019-05-15 13:30:36 PDT

Created attachment 369988 [details] Patch

Per Arne Vollan

Comment 3 2019-05-15 13:40:10 PDT

Comment on attachment 369988 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369988&action=review Looks good! R=me. > Source/WebKit/ChangeLog:5 > + Revise sandbox to allow IOKit properties needed by Metal and LaunchServices > + https://bugs.webkit.org/show_bug.cgi?id=197924 > + Do we have a Radar?

Brent Fulgham

Comment 4 2019-05-15 15:27:26 PDT

Committed r245360: <https://trac.webkit.org/changeset/245360>

Note You need to log in before you can comment on or make changes to this bug.