Bug 197905 – Make LOG_WITH_STREAM more efficient

• Component: New Bugs
• Status: RESOLVED FIXED

[Simon Fraser (smfr)]

Make LOG_WITH_STREAM more efficient

[Simon Fraser (smfr)]

Created attachment 369929 [details]
Patch

[Alex Christensen]

Comment on attachment 369929 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369929&action=review

> Source/WTF/wtf/text/TextStream.h:109
> +    struct repeat {
> +        repeat(char inCharacter, unsigned inWidth)
> +            : width(inWidth)
> +            , character(inCharacter)
> +        { }

I think this should be named Repeat.
I think initializer lists could be used instead of this constructor.

> Source/WebCore/PAL/pal/LogMacros.h:35
> +        if (JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel).state == WTFLogChannelState::On) { \

This seems like an obvious check we should've done before.

[Simon Fraser (smfr)]

(In reply to Alex Christensen from comment #2)
> Comment on attachment 369929 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=369929&action=review
> 
> > Source/WTF/wtf/text/TextStream.h:109
> > +    struct repeat {
> > +        repeat(char inCharacter, unsigned inWidth)
> > +            : width(inWidth)
> > +            , character(inCharacter)
> > +        { }
> 
> I think this should be named Repeat.
> I think initializer lists could be used instead of this constructor.

So the call site would look like:
stream << Repeat({' ', 10}) << "foopy"
?

[Alex Christensen]

(In reply to Simon Fraser (smfr) from comment #3)
stream << Repeat {' ', 10} << "foopy"

[Simon Fraser (smfr)]

Sadly the compiler doesn't like initializers inside a macro invocation:
/rendering/RenderLayerCompositor.cpp:1176:69: error: too many arguments provided to function-like macro invocation
    LOG_WITH_STREAM(Compositing, stream << TextStream::Repeat {' ', compositingState.depth * 2} << &layer << " computeCompositingRequirements - willBeComposited " << willBeComposited << " (backing provider candidate " << backingSharingState.backingProviderCandidate() << ")");

[Simon Fraser (smfr)]

Created attachment 369961 [details]
Patch

[Simon Fraser (smfr)]

https://trac.webkit.org/r245336

[Radar WebKit Bug Importer]

<rdar://problem/50820136>