Bug 197896

Summary: Web Automation: replace IntPoint/IntRect with FloatPoint/FloatRect when using CSS coordinates
Product: WebKit Reporter: Devin Rousso <hi>
Component: WebDriverAssignee: Devin Rousso <hi>
Status: NEW    
Severity: Normal CC: ahmad.saleem792, ap, bburg, bfulgham, graouts, hi, joepeck, simon.fraser, timothy, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 195696    
Bug Blocks:    
Attachments:
Description Flags
Patch hi: review?

Devin Rousso
Reported 2019-05-14 14:54:31 PDT
CSS coordinates can have decimal values, so we should be returning decimal values from WebDriver commands.
Attachments
Patch (14.22 KB, patch)
2019-06-02 15:18 PDT, Devin Rousso 		hi: review?
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-05-15 00:52:42 PDT
<rdar://problem/50801689>
Devin Rousso
Comment 2 2019-06-02 15:18:35 PDT
Created attachment 371164 [details] Patch I haven't tested this yet, as my local build isn't working :(
Blaze Burg
Comment 3 2019-09-04 11:13:14 PDT
Is there a functional reason to make this change? I.e., are tests newly passing with it applied?
Devin Rousso
Comment 4 2019-09-04 11:18:53 PDT
(In reply to Brian Burg from comment #3) > Is there a functional reason to make this change? I.e., are tests newly passing with it applied? Yes, but I don't remember which ones. I do remember that there were some tests that expected floating point bounding box values to match what `getBoundingClientRect` returns.
Ahmad Saleem
Comment 5 2022-09-22 14:49:38 PDT
Is it something still on radar for upstream or being worked on? Thanks!
Note You need to log in before you can comment on or make changes to this bug.