Bug 197844 – Correct the sandbox to allow loading libraries from /Library/Apple

• Component: WebKit2
• Status: RESOLVED FIXED

[Brent Fulgham]

Some InjectedBundles need to load libraries from "/Library/Apple", which is not allowed by default. Revise the sandbox to support this additional location for frameworks.

[Brent Fulgham]

Created attachment 369744 [details]
Patch

[Brent Fulgham]

<rdar://problem/50727815>

[Per Arne Vollan]

Comment on attachment 369744 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369744&action=review

R=me.

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:43
>  (allow file-read*
>      (require-all (file-mode #o0004)
>      (require-any (subpath "/Library/Filesystems/NetFSPlugins")
> +    (subpath "/Library/Apple/System")

Is this only needed for the injected bundle? If that is the case, maybe we could issue an extension? I don't think this is required now, and could be done in a followup patch.

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:63
> +;;; Allow mapping of system frameworks + dylibs
> +(allow file-map-executable
> +    (subpath "/Library/Apple/System/Library/Frameworks")
> +    (subpath "/Library/Apple/System/Library/PrivateFrameworks")
> +    (subpath "/System/Library/Frameworks")
> +    (subpath "/System/Library/PrivateFrameworks")
> +    (subpath "/usr/lib")

Ditto.

[Brent Fulgham]

Comment on attachment 369744 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369744&action=review

>> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:43
>> +    (subpath "/Library/Apple/System")
> 
> Is this only needed for the injected bundle? If that is the case, maybe we could issue an extension? I don't think this is required now, and could be done in a followup patch.

After reviewing things further, I think we should just treat this as another canonical location where system frameworks might live. It's not specific to injected bundles.

>> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:63
>> +    (subpath "/usr/lib")
> 
> Ditto.

This section might not be needed (yet), because we don't prohibit file mapping. But having this here will allow us to flip on that protection in a future patch.

[WebKit Commit Bot]

Comment on attachment 369744 [details]
Patch

Clearing flags on attachment: 369744

Committed r245246: <https://trac.webkit.org/changeset/245246>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.