Bug 19784

Summary: REGRESSION (r34787?): Text areas in Wikipedia edit pages are empty, following content is missing
Product: WebKit Reporter: mitz
Component: DOMAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Major CC: abarth
Priority: P1 Keywords: Regression
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
URL: http://en.wikipedia.org/w/index.php?title=Flowering_plant&action=edit
Attachments:
Description Flags
Step 1: Don't allow entities to start comments
darin: review+
Step 2: Handle unterminated comments correctly
darin: review+
Test case with properly encoded comment in textarea. none

Description mitz 2008-06-26 14:11:44 PDT 
It seems like no content is parsed after the beginning of the text area in Wikipedia edit pages, such as the above URL. The text area is empty and none of the rest of the DOM is present.
Comment 1 Adam Barth 2008-06-26 14:28:15 PDT 
I'll take a look at this when I get home tonight.
Comment 2 Adam Barth 2008-06-26 17:30:34 PDT 
Reduction <http://crypto.stanford.edu/~abarth/research/webkit/textarea/wikipedia.html>:

<html>
<body>
<textarea>
&lt;!-- 
</textarea>
</body>
</html>
Comment 3 Adam Barth 2008-06-26 20:49:04 PDT 
Created attachment 21966 [details]
Step 1: Don't allow entities to start comments

This fixes the wikipedia issue.
Comment 4 Adam Barth 2008-06-26 20:49:51 PDT 
Created attachment 21967 [details]
Step 2: Handle unterminated comments correctly
Comment 5 Darin Adler 2008-06-27 09:08:33 PDT 
Comment on attachment 21966 [details]
Step 1: Don't allow entities to start comments

It's be better if more of the new tests were text-only "dumpAsText" tests so they could be more portable cross-platform.

r=me
Comment 6 Darin Adler 2008-06-27 09:08:54 PDT 
Comment on attachment 21967 [details]
Step 2: Handle unterminated comments correctly

r=me
Comment 7 Darin Adler 2008-06-27 09:10:09 PDT 
Comment on attachment 21966 [details]
Step 1: Don't allow entities to start comments

Actually, it would be better to put the new condition at the *end* of the if statement to minimize the possibility of a performance regression in code that might be pretty hot.
Comment 8 Robert Wallis 2008-06-27 11:18:00 PDT 
Created attachment 21975 [details]
Test case with properly encoded comment in textarea.

This test case has an encoded comment tag in it, so it shouldn't be processing that comment tag.
Comment 9 Adam Barth 2008-06-27 11:25:24 PDT 
> This test case has an encoded comment tag in it, so it shouldn't be processing
> that comment tag.

Thanks for the test case Robert.  I believe the change I just committed in r34831 fixes this issue (including the test case you just attached).  I'm waiting for the buildbots to cycle before marking this issue as fixed.