| Summary: | Alter Conic Gradient tests to be less subject to noise | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Megan Gardner <megan_gardner> | ||||||
| Component: | New Bugs | Assignee: | Megan Gardner <megan_gardner> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bdakin, commit-queue, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=204250 | ||||||||
| Attachments: |
|
||||||||
|
Description
Megan Gardner
2019-05-10 17:25:13 PDT
Created attachment 369625 [details]
Patch
Comment on attachment 369625 [details]
Patch
Seems reasonable
Comment on attachment 369625 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369625&action=review r=me pending EWS > LayoutTests/ChangeLog:8 > + There is a currently a bug where there's a lot of detectable noise in > + the green gradients. Replace them with the less noisy magenta or blue. If there is a bug that needs to be fixed, can you reference it here or in a bug comment (just the radar number)? Comment on attachment 369625 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369625&action=review >> LayoutTests/ChangeLog:8 >> + the green gradients. Replace them with the less noisy magenta or blue. > > If there is a bug that needs to be fixed, can you reference it here or in a bug comment (just the radar number)? Good point! Also, very minor nit — the changelog description should go below the "Reviewed by" line. Created attachment 369778 [details]
Patch for landing
Comment on attachment 369778 [details] Patch for landing Clearing flags on attachment: 369778 Committed r245250: <https://trac.webkit.org/changeset/245250> All reviewed patches have been landed. Closing bug. |