Bug 197806

Summary: Alter Conic Gradient tests to be less subject to noise
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=204250
Attachments:
Description Flags
Patch
none
Patch for landing none

Megan Gardner
Reported 2019-05-10 17:25:13 PDT
Alter Conic Gradient tests to be less subject to noise
Attachments
Patch (11.06 KB, patch)
2019-05-10 17:36 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch for landing (11.09 KB, patch)
2019-05-13 13:50 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2019-05-10 17:36:16 PDT
Created attachment 369625 [details] Patch
Wenson Hsieh
Comment 2 2019-05-10 17:38:28 PDT
<rdar://problem/47272067>
Wenson Hsieh
Comment 3 2019-05-10 17:39:31 PDT
Comment on attachment 369625 [details] Patch Seems reasonable
Alexey Proskuryakov
Comment 4 2019-05-10 17:39:58 PDT
Comment on attachment 369625 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369625&action=review r=me pending EWS > LayoutTests/ChangeLog:8 > + There is a currently a bug where there's a lot of detectable noise in > + the green gradients. Replace them with the less noisy magenta or blue. If there is a bug that needs to be fixed, can you reference it here or in a bug comment (just the radar number)?
Wenson Hsieh
Comment 5 2019-05-10 17:41:41 PDT
Comment on attachment 369625 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369625&action=review >> LayoutTests/ChangeLog:8 >> + the green gradients. Replace them with the less noisy magenta or blue. > > If there is a bug that needs to be fixed, can you reference it here or in a bug comment (just the radar number)? Good point! Also, very minor nit — the changelog description should go below the "Reviewed by" line.
Megan Gardner
Comment 6 2019-05-13 13:50:26 PDT
Created attachment 369778 [details] Patch for landing
WebKit Commit Bot
Comment 7 2019-05-13 14:07:02 PDT
Comment on attachment 369778 [details] Patch for landing Clearing flags on attachment: 369778 Committed r245250: <https://trac.webkit.org/changeset/245250>
WebKit Commit Bot
Comment 8 2019-05-13 14:07:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.