Summary: | [WebAuthN] Make WebAuthN default on | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jiewen Tan <jiewen_tan> | ||||||||||
Component: | WebCore Misc. | Assignee: | Jiewen Tan <jiewen_tan> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | alex.gaynor, bfulgham, commit-queue, darin, ews-watchlist, jiewen_tan, kieun.shin, rniwa, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 181943 | ||||||||||||
Attachments: |
|
Description
Jiewen Tan
2019-05-10 17:10:23 PDT
Created attachment 369624 [details]
Patch
Comment on attachment 369624 [details] Patch Attachment 369624 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12158519 New failing tests: fast/dom/navigator-detached-no-crash.html Created attachment 369631 [details]
Archive of layout-test-results from ews101 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 369624 [details] Patch Attachment 369624 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12158672 New failing tests: fast/dom/navigator-detached-no-crash.html Created attachment 369634 [details]
Archive of layout-test-results from ews117 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117 Port: mac-highsierra Platform: Mac OS X 10.13.6
(In reply to Build Bot from comment #5) > fast/dom/navigator-detached-no-crash.html Need to rebase this test. (In reply to Darin Adler from comment #7) > (In reply to Build Bot from comment #5) > > fast/dom/navigator-detached-no-crash.html > > Need to rebase this test. I shouldn't change Source/WebCore/page/RuntimeEnabledFeatures.h which will enable WebAuthentication in LegacyWebKit. Thanks! Created attachment 369886 [details]
Patch
Comment on attachment 369886 [details] Patch Clearing flags on attachment: 369886 Committed r245329: <https://trac.webkit.org/changeset/245329> All reviewed patches have been landed. Closing bug. |