| Summary: | Bugzilla should convert "r12345" to a trac.webkit.org link | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||
| Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ap, clopez, commit-queue, ddkilzer, lforschler, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=224325 | ||||||||
| Attachments: |
|
||||||||
|
Description
Jer Noble
2019-05-10 11:57:38 PDT
Created attachment 369575 [details]
Patch
*** Bug 168722 has been marked as a duplicate of this bug. *** Comment on attachment 369575 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369575&action=review I guess this should work in the overwhelming majority of cases. > Websites/bugs.webkit.org/extensions/Trac/Extension.pm:32 > +use Bugzilla::Constants; > +use Bugzilla::Group; > +use Bugzilla::User; Which of these are actually used? > Websites/bugs.webkit.org/extensions/Trac/Extension.pm:38 > + my ($self, $args) = @_; > + my $regexes = $args->{'regexes'}; Too much indentation. > Websites/bugs.webkit.org/extensions/Trac/Extension.pm:49 > + return qq{<a href="//trac.webkit.org/$revision">$text</a>}; Why not say "https:"? These are separate servers, and while both are https only, there is no strict coupling. (In reply to Alexey Proskuryakov from comment #3) > Comment on attachment 369575 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=369575&action=review > > I guess this should work in the overwhelming majority of cases. Yep, and we can clean up and add more regex's if we come across more cases. > > Websites/bugs.webkit.org/extensions/Trac/Extension.pm:32 > > +use Bugzilla::Constants; > > +use Bugzilla::Group; > > +use Bugzilla::User; > > Which of these are actually used? Turns out, none. I've removed them and the extension still works. > > Websites/bugs.webkit.org/extensions/Trac/Extension.pm:38 > > + my ($self, $args) = @_; > > + my $regexes = $args->{'regexes'}; > > Too much indentation. Fixed. > > Websites/bugs.webkit.org/extensions/Trac/Extension.pm:49 > > + return qq{<a href="//trac.webkit.org/$revision">$text</a>}; > > Why not say "https:"? These are separate servers, and while both are https > only, there is no strict coupling. Sure; I guess we don't have to worry about CORS stuff during actual navigation. Created attachment 369782 [details]
Patch for landing
Comment on attachment 369782 [details] Patch for landing Clearing flags on attachment: 369782 Committed r245261: <https://trac.webkit.org/changeset/245261> All reviewed patches have been landed. Closing bug. |