Bug 197765

Summary: [JSC] String substring operation should return ropes consistently
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch msaboff: review+

Yusuke Suzuki
Reported 2019-05-09 20:29:14 PDT
[JSC] String substring operation should return ropes consistently
Attachments
Patch (6.36 KB, patch)
2019-05-09 20:42 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (7.02 KB, patch)
2019-05-10 10:41 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (7.03 KB, patch)
2019-05-10 12:31 PDT, Yusuke Suzuki 		msaboff: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-05-09 20:42:34 PDT
Created attachment 369541 [details] Patch
Yusuke Suzuki
Comment 2 2019-05-10 10:04:15 PDT
<rdar://problem/37689944>
Yusuke Suzuki
Comment 3 2019-05-10 10:41:38 PDT
Created attachment 369564 [details] Patch
Yusuke Suzuki
Comment 4 2019-05-10 12:31:51 PDT
Created attachment 369580 [details] Patch
Michael Saboff
Comment 5 2019-05-10 12:45:31 PDT
Comment on attachment 369580 [details] Patch r=me
Yusuke Suzuki
Comment 6 2019-05-10 13:49:43 PDT
Committed r245194: <https://trac.webkit.org/changeset/245194>
Yusuke Suzuki
Comment 7 2019-05-13 16:43:35 PDT
Ah, my investigation was wrong. While memory reduction is real, the effect comes from the fact that JSRopeString is cheaper than JSString + StringImpl. Not related StringImpl's substring sharing feature. So, maybe, we should just prefer JSRopeString for substring cases.
Note You need to log in before you can comment on or make changes to this bug.