Summary: | parseStatementListItem needs a stack overflow check | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Keith Miller <keith_miller> | ||||||
Component: | New Bugs | Assignee: | Keith Miller <keith_miller> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, ews-watchlist, mark.lam, msaboff, ryanhaddad, saam, webkit-bot-watchers-bugzilla, webkit-bug-importer, ysuzuki | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Keith Miller
2019-05-09 12:00:55 PDT
Created attachment 369506 [details]
Patch
Created attachment 369507 [details]
Patch
Comment on attachment 369507 [details]
Patch
r=me too :)
Comment on attachment 369507 [details] Patch Clearing flags on attachment: 369507 Committed r245152: <https://trac.webkit.org/changeset/245152> All reviewed patches have been landed. Closing bug. stress/many-nested-functions-parser-stack-overflow.js is failing on the release JSC bot: https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20JSC%20(Tests)/builds/9309/steps/jscore-test/logs/stdio It looks like jsc-ews saw the same: ** The following JSC stress test failures have been introduced: stress/many-nested-functions-parser-stack-overflow.js.bytecode-cache stress/many-nested-functions-parser-stack-overflow.js.default stress/many-nested-functions-parser-stack-overflow.js.dfg-eager stress/many-nested-functions-parser-stack-overflow.js.dfg-eager-no-cjit-validate stress/many-nested-functions-parser-stack-overflow.js.dfg-maximal-flush-validate-no-cjit stress/many-nested-functions-parser-stack-overflow.js.ftl-eager stress/many-nested-functions-parser-stack-overflow.js.ftl-eager-no-cjit stress/many-nested-functions-parser-stack-overflow.js.ftl-eager-no-cjit-b3o1 stress/many-nested-functions-parser-stack-overflow.js.ftl-no-cjit-b3o0 stress/many-nested-functions-parser-stack-overflow.js.ftl-no-cjit-no-inline-validate stress/many-nested-functions-parser-stack-overflow.js.ftl-no-cjit-no-put-stack-validate stress/many-nested-functions-parser-stack-overflow.js.ftl-no-cjit-small-pool stress/many-nested-functions-parser-stack-overflow.js.ftl-no-cjit-validate-sampling-profiler stress/many-nested-functions-parser-stack-overflow.js.no-cjit-collect-continuously stress/many-nested-functions-parser-stack-overflow.js.no-cjit-validate-phases stress/many-nested-functions-parser-stack-overflow.js.no-ftl stress/many-nested-functions-parser-stack-overflow.js.no-llint (In reply to Ryan Haddad from comment #8) > It looks like jsc-ews saw the same: > ** The following JSC stress test failures have been introduced: > stress/many-nested-functions-parser-stack-overflow.js.bytecode-cache > stress/many-nested-functions-parser-stack-overflow.js.default > stress/many-nested-functions-parser-stack-overflow.js.dfg-eager > stress/many-nested-functions-parser-stack-overflow.js.dfg-eager-no-cjit- > validate > stress/many-nested-functions-parser-stack-overflow.js.dfg-maximal-flush- > validate-no-cjit > stress/many-nested-functions-parser-stack-overflow.js.ftl-eager > stress/many-nested-functions-parser-stack-overflow.js.ftl-eager-no-cjit > stress/many-nested-functions-parser-stack-overflow.js.ftl-eager-no-cjit-b3o1 > stress/many-nested-functions-parser-stack-overflow.js.ftl-no-cjit-b3o0 > stress/many-nested-functions-parser-stack-overflow.js.ftl-no-cjit-no-inline- > validate > stress/many-nested-functions-parser-stack-overflow.js.ftl-no-cjit-no-put- > stack-validate > stress/many-nested-functions-parser-stack-overflow.js.ftl-no-cjit-small-pool > stress/many-nested-functions-parser-stack-overflow.js.ftl-no-cjit-validate- > sampling-profiler > stress/many-nested-functions-parser-stack-overflow.js.no-cjit-collect- > continuously > stress/many-nested-functions-parser-stack-overflow.js.no-cjit-validate- > phases > stress/many-nested-functions-parser-stack-overflow.js.no-ftl > stress/many-nested-functions-parser-stack-overflow.js.no-llint Should be fixed with: https://trac.webkit.org/changeset/245163 |