| Summary: | Limit number of prefetches of a given page | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Rob Buis <rbuis> | ||||||||
| Component: | Page Loading | Assignee: | Rob Buis <rbuis> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | beidson, cdumez, cgarcia, commit-queue, darin, ews-watchlist, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | Other | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Rob Buis
2019-05-09 05:39:25 PDT
Created attachment 369487 [details]
Patch
Created attachment 369489 [details]
Patch
Comment on attachment 369489 [details]
Patch
It’s unnecessary to design this so that it requires two separate functions in PrefetchCache and extra hash table lookups. Instead we could simply implement this policy in the prefetch cache itself. We would use add instead of set inside PrefetchCache::store, check the return value and return early if there’s already a prefetch for the URL. Currently, the single caller doesn’t even need to know whether the prefetch was done or not so we wouldn’t have to change anything outside that function.
Created attachment 369500 [details]
Patch
(In reply to Darin Adler from comment #3) > It’s unnecessary to design this so that it requires two separate functions > in PrefetchCache and extra hash table lookups. Instead we could simply > implement this policy in the prefetch cache itself. We would use add instead > of set inside PrefetchCache::store, check the return value and return early > if there’s already a prefetch for the URL. Currently, the single caller > doesn’t even need to know whether the prefetch was done or not so we > wouldn’t have to change anything outside that function. Much better, thanks! I updated the patch. Comment on attachment 369500 [details] Patch Clearing flags on attachment: 369500 Committed r245171: <https://trac.webkit.org/changeset/245171> All reviewed patches have been landed. Closing bug. |