Bug 197699

Summary:

Add plumbing for inactive system colors in RenderTheme cache

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

WebKit Misc.

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, commit-queue, ews-watchlist, megan_gardner, thorton

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews214 for win-future	none
Patch	none

Timothy Hatcher

Reported 2019-05-08 11:51:35 PDT

Some system colors that might be different when the view/window is inactive. We can't cache them in the same cache or the result will be wrong for subsequent cache accesses. <rdar://problem/49406936>

Attachments
Patch (24.78 KB, patch) 2019-05-08 12:01 PDT, Timothy Hatcher	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews214 for win-future (13.67 MB, application/zip) 2019-05-08 14:34 PDT, EWS Watchlist	no flags	Details
Patch (23.13 KB, patch) 2019-05-08 15:22 PDT, Timothy Hatcher	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Timothy Hatcher

Comment 1 2019-05-08 12:01:48 PDT Comment hidden (obsolete)

Created attachment 369403 [details] Patch

Tim Horton

Comment 2 2019-05-08 13:57:39 PDT

Comment on attachment 369403 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369403&action=review > Source/WebKit/ChangeLog:40 > +2019-05-08 Timothy Hatcher <timothy@apple.com> > + > + Add plumbing for inactive system colors for RenderTheme cache. > + https://bugs.webkit.org/show_bug.cgi?id=197699 > + Double changelog

EWS Watchlist

Comment 3 2019-05-08 14:34:43 PDT Comment hidden (obsolete)

Comment on attachment 369403 [details] Patch Attachment 369403 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12136282 New failing tests: security/contentSecurityPolicy/video-with-file-url-allowed-by-media-src-star.html http/tests/css/filters-on-iframes.html

EWS Watchlist

Comment 4 2019-05-08 14:34:45 PDT Comment hidden (obsolete)

Created attachment 369423 [details] Archive of layout-test-results from ews214 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews214 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

Timothy Hatcher

Comment 5 2019-05-08 15:22:08 PDT

Created attachment 369433 [details] Patch

Timothy Hatcher

Comment 6 2019-05-08 15:25:30 PDT

Committed r245072. https://trac.webkit.org/changeset/245072/webkit

Note You need to log in before you can comment on or make changes to this bug.