Bug 197690 – [GTK] Support navigation gesture on touchscreens

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Alice Mikhaylenko]

See the patch.

[Alice Mikhaylenko]

Created attachment 369370 [details]
Patch

[EWS Watchlist]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Alice Mikhaylenko]

mcatanzaro: I've decided to include the threshold change here at the end, because that change was motivated by wanting to use the same semantics for touchscreen and touchpad, and it's hard to explain on its own.

[EWS Watchlist]

Comment on attachment 369370 [details]
Patch

Attachment 369370 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/12132269

New failing tests:
imported/w3c/web-platform-tests/IndexedDB/idb-binary-key-roundtrip.htm

[EWS Watchlist]

Created attachment 369375 [details]
Archive of layout-test-results from ews116 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 369370 [details]
Patch

Attachment 369370 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12132358

New failing tests:
security/contentSecurityPolicy/video-with-file-url-allowed-by-media-src-star-with-AllowContentSecurityPolicySourceStarToMatchAnyProtocol-enabled.html
http/tests/css/filters-on-iframes.html

[EWS Watchlist]

Created attachment 369376 [details]
Archive of layout-test-results from ews213 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews213  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[Michael Catanzaro]

Comment on attachment 369370 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369370&action=review

> Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp:40
> +static const double gtkScrollDeltaMultiplier = 10;

A lot of users have been complaining that scrolling the web view doesn't move the web content as much as in other browsers. Is that something you'd be interested in trying to improve?

> Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp:190
> +    if (isTouchEvent(event))
> +        deltaX *= (double) Scrollbar::pixelsPerLineStep() / m_webPageProxy.viewSize().width();
> +    else
> +        deltaX *= gtkScrollDeltaMultiplier / swipeTouchpadBaseWidth;

Just make sure the divisors can never be zero.

[Alice Mikhaylenko]

> Just make sure the divisors can never be zero.

I.e. the width? One of them is constant, the other one... Can there be a situation where viewport size is zero and you can perform a swipe? :o

> A lot of users have been complaining that scrolling the web view doesn't move the web content as much as in other browsers. Is that something you'd be interested in trying to improve?

I can look at it, but I need more details. The "other browsers" are presumably Firefox, since Chrome doesn't support pixel-perfect touchpad scrolling in the first place. I'd personally prefer it to match GTK behavior.

Links to a request would be appreciated, maybe it meant mouse scrolling, which is a completely different thing anyway.

[Michael Catanzaro]

(In reply to Alexander Mikhaylenko from comment #9)
> > Just make sure the divisors can never be zero.
> 
> I.e. the width? One of them is constant, the other one... Can there be a
> situation where viewport size is zero and you can perform a swipe? :o

Probably not, I just wanted you to think about it.

> I can look at it, but I need more details. The "other browsers" are
> presumably Firefox, since Chrome doesn't support pixel-perfect touchpad
> scrolling in the first place. I'd personally prefer it to match GTK behavior.
> 
> Links to a request would be appreciated, maybe it meant mouse scrolling,
> which is a completely different thing anyway.

It's a separate issue. Don't worry about it here.

[Alice Mikhaylenko]

Just in case checked with GTK_OVERLAY_SCROLLING=0. Viewport size still doesn't change.

[Alice Mikhaylenko]

Created attachment 369391 [details]
Patch

Err, I missed "Moved ViewGestureController" in the description, that was a placeholder I meant to fill later. :) Done

[WebKit Commit Bot]

Comment on attachment 369391 [details]
Patch

Clearing flags on attachment: 369391

Committed r245065: <https://trac.webkit.org/changeset/245065>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.