Bug 197674 – Simplify logic to prevent App Nap in WebPage

• Component: WebKit2
• Status: RESOLVED FIXED

[Chris Dumez]

Simplify logic to prevent App Nap login in WebPage. We do not need both m_userActivityHysteresis and m_userActivity since UserActivity is already a HysteresisActivity.

[Chris Dumez]

Created attachment 369326 [details]
Patch

[Chris Dumez]

Created attachment 369327 [details]
Patch

[Geoffrey Garen]

Comment on attachment 369327 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369327&action=review

r=me

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:768
> +    bool shouldAllowAppNapGivenPageState = m_isAppNapEnabled && !isActive && isVisuallyIdle;

Maybe call this isAppNapEnabledInThisPage. The if-then ("A given B") style of naming threw me off a bit.

[Chris Dumez]

Created attachment 369329 [details]
Patch

[EWS Watchlist]

Comment on attachment 369329 [details]
Patch

Attachment 369329 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12127898

New failing tests:
http/tests/css/filters-on-iframes.html

[EWS Watchlist]

Created attachment 369334 [details]
Archive of layout-test-results from ews215 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews215  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[Alex Christensen]

Comment on attachment 369329 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369329&action=review

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:419
> +    , m_isAppNapEnabled(true)

While we're touching these, could we use initializer lists in the header?

[Chris Dumez]

(In reply to Alex Christensen from comment #7)
> Comment on attachment 369329 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=369329&action=review
> 
> > Source/WebKit/WebProcess/WebPage/WebPage.cpp:419
> > +    , m_isAppNapEnabled(true)
> 
> While we're touching these, could we use initializer lists in the header?

Good point, will fix before landing.

[Chris Dumez]

Created attachment 369345 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 369345 [details]
Patch

Clearing flags on attachment: 369345

Committed r245048: <https://trac.webkit.org/changeset/245048>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/50564901>