Summary: | Regression: Crash at WebKit: PAL::HysteresisActivity::start | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||||||||
Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||
Severity: | Normal | CC: | achristensen, andersca, beidson, commit-queue, ews-watchlist, ggaren, sihui_liu, webkit-bug-importer | ||||||||||||||||
Priority: | P2 | Keywords: | InRadar, Regression | ||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||
Attachments: |
|
Description
Chris Dumez
2019-05-07 10:49:58 PDT
Created attachment 369302 [details]
Patch
Created attachment 369307 [details]
Patch
Created attachment 369323 [details]
Patch
Is it really OK to rely on pointer equality like this? What if the client gets deallocated and a new client with the same address gets deallocated? (In reply to Anders Carlsson from comment #5) > Is it really OK to rely on pointer equality like this? What if the client > gets deallocated and a new client with the same address gets deallocated? It seems possible in theory. I'll find a more robust approach. Comment on attachment 369323 [details] Patch Attachment 369323 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12128243 New failing tests: legacy-animation-engine/compositing/reflections/load-video-in-reflection.html Created attachment 369343 [details]
Archive of layout-test-results from ews214 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews214 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Created attachment 369348 [details]
Patch
Created attachment 369349 [details]
Patch
Comment on attachment 369349 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369349&action=review r=me > Source/WebKit/ChangeLog:18 > + 1. The constructor takes in a WTF::Function instead of a NetworkProcess / WebProcess crash. This is provides crash => reference > Source/WebKit/Shared/WebSQLiteDatabaseTracker.cpp:52 > + notifyClient(false); I'd say bool isHoldingLockedFiles = false; notifyClient(isHoldingLockedFiles); to avoid a cryptic boolean argument. (I prefer this style to adding a comment about the meaning of the boolean argument. Code speaks. Comments mumble.) Created attachment 369411 [details]
Patch
Comment on attachment 369411 [details] Patch Clearing flags on attachment: 369411 Committed r245069: <https://trac.webkit.org/changeset/245069> All reviewed patches have been landed. Closing bug. |