Summary: | [GTK][WPE] Cannot build documentation with gtk-doc | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adrian Perez <aperez> | ||||||
Component: | Tools / Tests | Assignee: | Adrian Perez <aperez> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | berto, cgarcia, commit-queue, ews-watchlist, gustavo, lforschler, mcatanzaro, pnormand, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | Other | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Adrian Perez
2019-05-07 09:03:08 PDT
Created attachment 369290 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 369290 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369290&action=review Oops. My bad :/ > Source/WebKit/ChangeLog:11 > + tag names in the documentation for the WebKitSettings:enabl-media property. little typo in enabl-media ;) (In reply to Philippe Normand from comment #3) > Comment on attachment 369290 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=369290&action=review > > Oops. My bad :/ > > > Source/WebKit/ChangeLog:11 > > + tag names in the documentation for the WebKitSettings:enabl-media property. > > little typo in enabl-media ;) Nice catch. I'll fix the typo and then land the updated patch. Thanks! Created attachment 369311 [details]
Patch for landing
Comment on attachment 369311 [details] Patch for landing Clearing flags on attachment: 369311 Committed r245027: <https://trac.webkit.org/changeset/245027> All reviewed patches have been landed. Closing bug. |