Bug 197653

Summary: [GTK] Crash in webkitWebViewBaseSetEnableBackForwardNavigationGesture
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, bugs-noreply, ews-watchlist, gns, mcatanzaro, zan
Priority: P2 Keywords: Gtk, Regression
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch zan: review+

Description Carlos Garcia Campos 2019-05-07 02:55:22 PDT
We still need to null-check the ViewGestureController there, since it can be called with a running process but not yet attached when using a related view.

#0  0x00007fe8b7b8268d in webkitWebViewBaseSetEnableBackForwardNavigationGesture(_WebKitWebViewBase*, bool) ()
   from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#1  0x00007fe8b7b64387 in webkitWebViewUpdateSettings(_WebKitWebView*) [clone .part.323] () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#2  0x00007fe8b7b67a2d in webkitWebViewConstructed(_GObject*) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#3  0x00007fe8b51ed6c3 in g_object_new_internal (class=class@entry=0x55e84513d160, params=params@entry=0x7ffcebc72020, n_params=n_params@entry=3) at ../gobject/gobject.c:1844
#4  0x00007fe8b51ef214 in g_object_new_valist (object_type=<optimized out>, first_property_name=<optimized out>, var_args=var_args@entry=0x7ffcebc72168) at ../gobject/gobject.c:2127
#5  0x00007fe8b51ef53c in g_object_new (object_type=<optimized out>, first_property_name=<optimized out>) at ../gobject/gobject.c:1647
#6  0x00007fe8b7b87342 in webkit_web_view_new_with_related_view () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#7  0x000055e843d2a68a in webViewCreate ()
#8  0x00007fe8ae4da8ee in ffi_call_unix64 () from /lib/x86_64-linux-gnu/libffi.so.6
#9  0x00007fe8ae4da2bf in ffi_call () from /lib/x86_64-linux-gnu/libffi.so.6
#10 0x00007fe8b51e85a9 in g_cclosure_marshal_generic (closure=0x55e84518e2a0, return_gvalue=0x7ffcebc725c0, n_param_values=<optimized out>, param_values=<optimized out>, 
    invocation_hint=<optimized out>, marshal_data=<optimized out>) at ../gobject/gclosure.c:1500
#11 0x00007fe8b51e7ddd in g_closure_invoke (closure=0x55e84518e2a0, return_value=0x7ffcebc725c0, n_param_values=2, param_values=0x7ffcebc72670, invocation_hint=0x7ffcebc72610)
    at ../gobject/gclosure.c:810
#12 0x00007fe8b51fadb5 in signal_emit_unlocked_R (node=<optimized out>, detail=detail@entry=0, instance=instance@entry=0x55e844d7f950, emission_return=emission_return@entry=0x7ffcebc72760, 
    instance_and_params=instance_and_params@entry=0x7ffcebc72670) at ../gobject/gsignal.c:3635
#13 0x00007fe8b5203530 in g_signal_emit_valist (instance=<optimized out>, signal_id=<optimized out>, detail=<optimized out>, var_args=var_args@entry=0x7ffcebc72818)
    at ../gobject/gsignal.c:3401
#14 0x00007fe8b52044d2 in g_signal_emit (instance=<optimized out>, signal_id=<optimized out>, detail=<optimized out>) at ../gobject/gsignal.c:3447
#15 0x00007fe8b7b66a3f in webkitWebViewCreateNewPage(_WebKitWebView*, WebCore::WindowFeatures const&, _WebKitNavigationAction*) ()
Comment 1 Carlos Garcia Campos 2019-05-07 02:57:20 PDT
Created attachment 369266 [details]
Patch
Comment 2 EWS Watchlist 2019-05-07 02:59:04 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Carlos Garcia Campos 2019-05-07 07:34:03 PDT
Committed r245008: <https://trac.webkit.org/changeset/245008>