| Summary: | iOSMac Share Sheet shows up at the wrong place | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, megan_gardner, webkit-bug-importer, wenson_hsieh | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Tim Horton
2019-05-07 01:17:45 PDT
Created attachment 369255 [details]
Patch
Comment on attachment 369255 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369255&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:5838 > + } Is there no way to make a Rect from a Point? That seems like a thing we would want. I’m also assuming that it expands the rect to whatever size is best, and that giving it this start location is the best option. Comment on attachment 369255 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369255&action=review Actually <rdar://problem/49922942> > Source/WebKit/ChangeLog:5 > + <rdar://problem/50295563> This should be rdar://problem/49922942 Comment on attachment 369255 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369255&action=review >> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:5838 >> + } > > Is there no way to make a Rect from a Point? That seems like a thing we would want. > I’m also assuming that it expands the rect to whatever size is best, and that giving it this start location is the best option. There are ways, but IMO they're uglier (maybe not anymore with {{{{{}}}}} magic) It's a rect to present *from*, so giving it one point just means that's where the popover arrow (or context menu) appears to originate from/point to. |