Bug 197637

Summary: WTF::BitVector should have an isEmpty() method
Product: WebKit Reporter: Robin Morisset <rmorisset>
Component: JavaScriptCoreAssignee: Robin Morisset <rmorisset>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 197857    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews214 for win-future none

Robin Morisset
Reported 2019-05-06 16:40:22 PDT
The register allocator in Air repeatedly calls bitCount() on BitVectors only to compare with 0. It would be cleaner to have isEmpty(), and it is probably also a tad faster (although not measurably so out of microbenchmarks).
Attachments
Patch (4.77 KB, patch)
2019-05-06 16:43 PDT, Robin Morisset 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews214 for win-future (13.45 MB, application/zip)
2019-05-06 20:13 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Robin Morisset
Comment 1 2019-05-06 16:43:25 PDT
Created attachment 369202 [details] Patch
EWS Watchlist
Comment 2 2019-05-06 20:13:10 PDT
Comment on attachment 369202 [details] Patch Attachment 369202 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12118631 New failing tests: security/contentSecurityPolicy/video-with-file-url-allowed-by-media-src-star.html
EWS Watchlist
Comment 3 2019-05-06 20:13:12 PDT
Created attachment 369222 [details] Archive of layout-test-results from ews214 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews214 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Keith Miller
Comment 4 2019-05-06 20:37:05 PDT
Comment on attachment 369202 [details] Patch r=me.
Robin Morisset
Comment 5 2019-05-07 12:30:22 PDT
Comment on attachment 369202 [details] Patch The windows test failure also appears without my patch so it looks like usual brokenness of the windows build.
WebKit Commit Bot
Comment 6 2019-05-07 13:46:50 PDT
Comment on attachment 369202 [details] Patch Clearing flags on attachment: 369202 Committed r245030: <https://trac.webkit.org/changeset/245030>
WebKit Commit Bot
Comment 7 2019-05-07 13:46:51 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-05-07 13:47:29 PDT
<rdar://problem/50553781>
Note You need to log in before you can comment on or make changes to this bug.