Bug 197568
| Summary: | Investigate no longer resolving symlinks when creating a SandboxExtension | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> |
| Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> |
| Status: | REOPENED | ||
| Severity: | Normal | CC: | ap, bfulgham, darin, mjs, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=197389 | ||
| Bug Depends on: | 197389 | ||
| Bug Blocks: | |||
Brent Fulgham
When we originally wrote the SandboxExtension logic for handling files, we believed that they had to be defined in terms of the canonical paths on the file system. We added logic to resolve symlinks prior to issuing the extensions.
We now know that this is unnecessary work, and could be avoided entirely. This is likely to improve performance of certain file operations, and should be investigated as a way to further improve performance.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Brent Fulgham
<rdar://problem/14062743>
Brent Fulgham
After discussing this with Sandbox experts, it is not true that we can avoid resolving symlinks. We should not pursue this idea.
Brent Fulgham
Whoops -- we need fully-resolved names in Sandbox profile rules. But I think we can pass a sandbox extension to a path containing symlinks, and it's usable.