| Summary: | run-api-tests: Add --iterations and --repeat-each | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Shawn Roberts <sroberts> | ||||||||
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Enhancement | CC: | aakash_jain, commit-queue, ews-watchlist, glenn, jbedard, lforschler, ryanhaddad, webkit-bot-watchers-bugzilla, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=198425 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Shawn Roberts
2019-05-03 09:32:48 PDT
Created attachment 368940 [details]
Patch
I'm actually surprised we don't already do this. In any case, it's an easy enough change. Comment on attachment 368940 [details] Patch Attachment 368940 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12090443 New failing tests: fast/shadow-dom/svg-text-path-href-change-in-shadow-tree.html Created attachment 368972 [details]
Archive of layout-test-results from ews210 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews210 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment on attachment 368940 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368940&action=review > Tools/Scripts/webkitpy/api_tests/manager.py:185 > + test_names = [test for test in test_names for _ in xrange(self._options.repeat_each)] It feels little weird to duplicate the list of test_names. Maybe a cleaner approach would be to run a for loop, and also log a message with iteration number, so that it's easier for someone to find out when a iteration is complete. > Tools/Scripts/webkitpy/api_tests/manager.py:186 > + test_names *= self._options.iterations Maybe worth adding a log indicating the number of iterations. Created attachment 369029 [details]
Patch for landing
Comment on attachment 369029 [details] Patch for landing Clearing flags on attachment: 369029 Committed r244942: <https://trac.webkit.org/changeset/244942> All reviewed patches have been landed. Closing bug. |