Bug 197538

Summary:

Web Inspector: Styles: use the same green color for modified properties as in Changes panel

Product:

WebKit

Reporter:

Nikita Vasilyev <nvasilyev>

Component:

Web Inspector

Assignee:

Nikita Vasilyev <nvasilyev>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[Image] Before	none
Patch	timothy: review+
[Image] After	none
Archive of layout-test-results from ews212 for win-future	none
Patch	none

Nikita Vasilyev

Reported 2019-05-02 18:00:40 PDT

Created attachment 368855 [details] [Image] Before Currently, it's two different shades of green.

Attachments
[Image] Before (52.96 KB, image/png) 2019-05-02 18:00 PDT, Nikita Vasilyev	no flags	Details
Patch (4.96 KB, patch) 2019-05-02 18:02 PDT, Nikita Vasilyev	timothy: review+	Details Formatted Diff Diff
[Image] After (51.77 KB, image/png) 2019-05-02 18:05 PDT, Nikita Vasilyev	no flags	Details
Archive of layout-test-results from ews212 for win-future (13.66 MB, application/zip) 2019-05-03 01:12 PDT, EWS Watchlist	no flags	Details
Patch (5.07 KB, patch) 2019-05-04 17:24 PDT, Nikita Vasilyev	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Nikita Vasilyev

Comment 1 2019-05-02 18:02:50 PDT

Created attachment 368856 [details] Patch

Nikita Vasilyev

Comment 2 2019-05-02 18:05:11 PDT

Created attachment 368857 [details] [Image] After

EWS Watchlist

Comment 3 2019-05-03 01:12:41 PDT Comment hidden (obsolete)

Comment on attachment 368856 [details] Patch Attachment 368856 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12081035 New failing tests: svg/repaint/change-background-color.html security/contentSecurityPolicy/video-with-file-url-allowed-by-media-src-star.html

EWS Watchlist

Comment 4 2019-05-03 01:12:43 PDT Comment hidden (obsolete)

Created attachment 368913 [details] Archive of layout-test-results from ews212 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews212 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

Nikita Vasilyev

Comment 5 2019-05-03 03:35:04 PDT

Comment on attachment 368856 [details] Patch Unrelated test failures.

Devin Rousso

Comment 6 2019-05-03 19:33:03 PDT

Comment on attachment 368856 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368856&action=review > Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:134 > + border-right-color: hsl(90, 100%, 40%); Why not also make this into a variable, like `diff-addition-border-color`? > Source/WebInspectorUI/UserInterface/Views/Variables.css:183 > + --diff-addition-background: hsl(70, 90%, 86%); We normally still add a `-color` suffix, even for `*-background`. > Source/WebInspectorUI/UserInterface/Views/Variables.css:185 > + --diff-deletion-background: hsl(5, 100%, 94%); Ditto (>183). > Source/WebInspectorUI/UserInterface/Views/Variables.css:337 > + --diff-addition-background: hsl(90, 40%, 19%); Ditto (>183). > Source/WebInspectorUI/UserInterface/Views/Variables.css:339 > + --diff-deletion-background: hsl(5, 40%, 28%); Ditto (>183).

Nikita Vasilyev

Comment 7 2019-05-04 17:24:13 PDT

Created attachment 369079 [details] Patch

WebKit Commit Bot

Comment 8 2019-05-04 18:02:02 PDT

Comment on attachment 369079 [details] Patch Clearing flags on attachment: 369079 Committed r244951: <https://trac.webkit.org/changeset/244951>

WebKit Commit Bot

Comment 9 2019-05-04 18:02:03 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 10 2019-05-04 18:03:19 PDT

<rdar://problem/50475509>

Note You need to log in before you can comment on or make changes to this bug.