| Summary: | Web Inspector: Styles: use the same green color for modified properties as in Changes panel | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Nikita Vasilyev <nvasilyev> | ||||||||||||
| Component: | Web Inspector | Assignee: | Nikita Vasilyev <nvasilyev> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, timothy, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | All | ||||||||||||||
| OS: | All | ||||||||||||||
| Attachments: |
|
||||||||||||||
Created attachment 368856 [details]
Patch
Created attachment 368857 [details]
[Image] After
Comment on attachment 368856 [details] Patch Attachment 368856 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12081035 New failing tests: svg/repaint/change-background-color.html security/contentSecurityPolicy/video-with-file-url-allowed-by-media-src-star.html Created attachment 368913 [details]
Archive of layout-test-results from ews212 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews212 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment on attachment 368856 [details]
Patch
Unrelated test failures.
Comment on attachment 368856 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368856&action=review > Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:134 > + border-right-color: hsl(90, 100%, 40%); Why not also make this into a variable, like `diff-addition-border-color`? > Source/WebInspectorUI/UserInterface/Views/Variables.css:183 > + --diff-addition-background: hsl(70, 90%, 86%); We normally still add a `-color` suffix, even for `*-background`. > Source/WebInspectorUI/UserInterface/Views/Variables.css:185 > + --diff-deletion-background: hsl(5, 100%, 94%); Ditto (>183). > Source/WebInspectorUI/UserInterface/Views/Variables.css:337 > + --diff-addition-background: hsl(90, 40%, 19%); Ditto (>183). > Source/WebInspectorUI/UserInterface/Views/Variables.css:339 > + --diff-deletion-background: hsl(5, 40%, 28%); Ditto (>183). Created attachment 369079 [details]
Patch
Comment on attachment 369079 [details] Patch Clearing flags on attachment: 369079 Committed r244951: <https://trac.webkit.org/changeset/244951> All reviewed patches have been landed. Closing bug. |
Created attachment 368855 [details] [Image] Before Currently, it's two different shades of green.