Bug 197529

Summary:

Add a quirk to make gmail navigation bar scrollable without mouse hover on iOS

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, ggaren, simon.fraser

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=197555

Attachments:

Description	Flags
patch	simon.fraser: review+, simon.fraser: commit-queue-
patch	none

Description Antti Koivisto 2019-05-02 13:41:00 PDT

The left side bar requires mouseover to become scrollable.

Comment 1 Antti Koivisto 2019-05-02 13:47:43 PDT

<rdar://problem/49403416>

Comment 2 Antti Koivisto 2019-05-02 13:56:38 PDT

Created attachment 368818 [details]
patch

Comment 3 Simon Fraser (smfr) 2019-05-02 16:28:38 PDT

Comment on attachment 368818 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368818&action=review

> Source/WebCore/page/Quirks.cpp:271
> +    if (!m_needsGMailOverflowScrollQuirk)

This should also do the if (!needsQuirks()) check.

Comment 4 Antti Koivisto 2019-05-02 23:09:01 PDT

Created attachment 368904 [details]
patch

Comment 5 WebKit Commit Bot 2019-05-02 23:48:19 PDT

Comment on attachment 368904 [details]
patch

Clearing flags on attachment: 368904

Committed r244904: <https://trac.webkit.org/changeset/244904>

Comment 6 WebKit Commit Bot 2019-05-02 23:48:21 PDT

All reviewed patches have been landed.  Closing bug.