Bug 197524
| Summary: | Remove needsAppIdQuirks in 2023 | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jiewen Tan <jiewen_tan> |
| Component: | WebCore Misc. | Assignee: | Ryosuke Niwa <rniwa> |
| Status: | RESOLVED LATER | ||
| Severity: | Normal | CC: | ahmad.saleem792, ap, bfulgham, cdumez, commit-queue, james, jiewen_tan, pascoe, rniwa, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 246032 | ||
| Bug Blocks: | |||
Jiewen Tan
Remove needsAppIdQuirks in 2023.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
https://github.com/WebKit/WebKit/blob/6bd8e23cd7a92e9c5e92fc130b31b4351bfa19b7/Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp#L56
I tried to search "needsAppIdQuirks" in https://source.chromium.org but couldn't find anything.
Is there any update? Thanks!
Alexey Proskuryakov
Source//WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp:static bool needsAppIdQuirks(const String& host, const String& appId)
Source//WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp: if (!appIdURL.isValid() || facetId.protocol() != appIdURL.protocol() || (RegistrableDomain(appIdURL) != RegistrableDomain::uncheckedCreateFromHost(facetId.host()) && !needsAppIdQuirks(facetId.host(), appId)))
This can probably be removed right now.
Ryosuke Niwa
Pull request: https://github.com/WebKit/WebKit/pull/4968
EWS
Committed 255131@main (e289f6f60014): <https://commits.webkit.org/255131@main>
Reviewed commits have been landed. Closing PR #4968 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/100768951>
pascoe@apple.com
Google still actively uses this quirk and login breaks without it. I think we will need to consult before removing this quirk.
pascoe@apple.com
This quirk is still in Chrome: https://github.com/chromium/chromium/blob/829d766699652d4678325623846cf5a33f996f4f/content/browser/webauth/webauth_request_security_checker.cc#L307
WebKit Commit Bot
Re-opened since this is blocked by bug 246032
Ahmad Saleem
Hi Team - we have now passed original time of January 2023. Can we check whether we can remove it or not? Or update comment to track it for future? Thanks!
Ryosuke Niwa
Quirk is still present in Chromium:
https://github.com/chromium/chromium/blob/776ba6a94375a2ab65bd6924859e2de628328cd2/content/browser/webauth/webauth_request_security_checker.cc#LL201C42-L201C52