Bug 197518

Summary: [lldb-webkit] Support adding pretty-printing for qualified types
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Tools / TestsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ews-watchlist, lforschler, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews212 for win-future none

Daniel Bates
Reported 2019-05-02 10:13:39 PDT
Support adding pretty-printing for qualified types (e.g. WebCore::MapCoordinatesFlags <-- yeah, we should convert this to a OptionSet).
Attachments
Patch (1.92 KB, patch)
2019-05-02 10:18 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews212 for win-future (13.42 MB, application/zip)
2019-05-02 15:43 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2019-05-02 10:18:13 PDT
Created attachment 368783 [details] Patch
EWS Watchlist
Comment 2 2019-05-02 15:43:17 PDT
Comment on attachment 368783 [details] Patch Attachment 368783 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12066263 New failing tests: svg/dynamic-updates/SVGLinearGradientElement-svgdom-href-prop.html svg/dynamic-updates/SVGRadialGradientElement-svgdom-href-prop.html
EWS Watchlist
Comment 3 2019-05-02 15:43:19 PDT
Created attachment 368828 [details] Archive of layout-test-results from ews212 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews212 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Daniel Bates
Comment 4 2019-05-03 16:13:34 PDT
Comment on attachment 368783 [details] Patch Clearing flags on attachment: 368783 Committed r244934: <https://trac.webkit.org/changeset/244934>
Daniel Bates
Comment 5 2019-05-03 16:13:35 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-05-03 16:14:24 PDT
<rdar://problem/50461115>
Note You need to log in before you can comment on or make changes to this bug.