Summary: | Web Inspector: Timelines: imported recordings do not have JavaScript call trees | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||
Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, hi, inspector-bugzilla-changes, joepeck, tsavell, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Devin Rousso
2019-05-02 00:55:09 PDT
Created attachment 371719 [details]
Patch
Comment on attachment 371719 [details]
Patch
I'm not sure if this actually "fixes" the issue completely (e.g. there may be other changes, like all the `FIXME: CallFrames`, but with this change the "Call Trees" view is no longer empty :)
Comment on attachment 371719 [details]
Patch
r=me
Comment on attachment 371719 [details] Patch Clearing flags on attachment: 371719 Committed r246292: <https://trac.webkit.org/changeset/246292> All reviewed patches have been landed. Closing bug. The changes in https://trac.webkit.org/changeset/246292/webkit has broken inspector/timeline/timeline-recording.html There are a lot of added lines in the diff. Did this test just need a rebasline? History: http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Ftimeline%2Ftimeline-recording.html Diff: https://build.webkit.org/results/Apple%20Mojave%20Release%20WK2%20(Tests)/r246309%20(4628)/inspector/timeline/timeline-recording-diff.txt (In reply to Truitt Savell from comment #8) > The changes in https://trac.webkit.org/changeset/246292/webkit > > has broken inspector/timeline/timeline-recording.html > > There are a lot of added lines in the diff. Did this test just need a rebasline? > > History: > http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard. html#showAllRuns=true&tests=inspector%2Ftimeline%2Ftimeline-recording.html > > Diff: > https://build.webkit.org/results/Apple%20Mojave%20Release%20WK2%20(Tests)/r246309%20(4628)/inspector/timeline/timeline-recording-diff.txt Committed r246317: <https://trac.webkit.org/r246317> |