Bug 197488

Summary: Disable software keyboard for a math field textarea on desmos.com
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, esprehn+autocc, ews-watchlist, ggaren, gyuyoung.kim, megan_gardner, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fixes the bug
wenson_hsieh: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews211 for win-future none

Description Ryosuke Niwa 2019-05-01 21:33:16 PDT 
Having software keyboard on this website interferes with website's UI.
Disable it with a site specific quirk for now.

<rdar://problem/49403904>
Comment 1 Ryosuke Niwa 2019-05-01 21:46:20 PDT 
Created attachment 368760 [details]
Fixes the bug
Comment 2 Wenson Hsieh 2019-05-01 22:20:36 PDT 
Comment on attachment 368760 [details]
Fixes the bug

r=me, with an UNUSED_PARAM to fix non-iOS-family builds.
Comment 3 EWS Watchlist 2019-05-02 11:24:23 PDT 
Comment on attachment 368760 [details]
Fixes the bug

Attachment 368760 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12063465

New failing tests:
svg/dynamic-updates/SVGRadialGradientElement-svgdom-href-prop.html
Comment 4 EWS Watchlist 2019-05-02 11:24:37 PDT 
Created attachment 368794 [details]
Archive of layout-test-results from ews211 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews211  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 5 Brent Fulgham 2019-05-02 13:21:30 PDT 
Comment on attachment 368760 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=368760&action=review

> Source/WebCore/page/Quirks.cpp:270
> +#if PLATFORM(IOS_FAMILY)

Maybe we should add a comment:

// FIXME(<rdar://problem/50394969>): Remove after site corrects content

(or something?)
Comment 6 Ryosuke Niwa 2019-05-02 13:53:51 PDT 
(In reply to Brent Fulgham from comment #5)
> Comment on attachment 368760 [details]
> Fixes the bug
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=368760&action=review
> 
> > Source/WebCore/page/Quirks.cpp:270
> > +#if PLATFORM(IOS_FAMILY)
> 
> Maybe we should add a comment:
> 
> // FIXME(<rdar://problem/50394969>): Remove after site corrects content
> 
> (or something?)

Sure.
Comment 7 Ryosuke Niwa 2019-05-02 16:31:44 PDT 
Committed r244894: <https://trac.webkit.org/changeset/244894>