Bug 197481

Summary:

[WebAuthN] Adopt SecurityOrigin::isMatchingRegistrableDomainSuffix()

Product:

WebKit

Reporter:

Jiewen Tan <jiewen_tan>

Component:

WebCore Misc.

Assignee:

Jiewen Tan <jiewen_tan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, ews-watchlist, jiewen_tan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

181943

Attachments:

Description	Flags
Patch	bfulgham: review+, ews-watchlist: commit-queue-
Patch for landing	none
Archive of layout-test-results from ews126 for ios-simulator-wk2	none

Jiewen Tan

Reported 2019-05-01 15:23:03 PDT

Adopt SecurityOrigin::isMatchingRegistrableDomainSuffix().

Attachments
Patch (10.52 KB, patch) 2019-05-01 15:32 PDT, Jiewen Tan	bfulgham: review+ ews-watchlist: commit-queue-	Details Formatted Diff Diff
Patch for landing (10.48 KB, patch) 2019-05-01 18:40 PDT, Jiewen Tan	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (8.70 MB, application/zip) 2019-05-01 18:44 PDT, EWS Watchlist	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Jiewen Tan

Comment 1 2019-05-01 15:32:24 PDT

Created attachment 368722 [details] Patch

Brent Fulgham

Comment 2 2019-05-01 17:16:55 PDT

Comment on attachment 368722 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368722&action=review Looks good! I would adjust the comments slightly, but no further review is needed. > Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp:131 > + // be domains or IP addresses. https://url.spec.whatwg.org/#url-representation I think it might be simpler to just say: "The effective domain may be represented in various manners, such as a domain or an ip address. Only the domain format of host is permitted in WebAuthN. > Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp:198 > + // be a domain or an IP address. https://url.spec.whatwg.org/#url-representation Ditto: I think it might be simpler to just say: "The effective domain may be represented in various manners, such as a domain or an ip address. Only the domain format of host is permitted in WebAuthN.

Jiewen Tan

Comment 3 2019-05-01 18:39:30 PDT

Comment on attachment 368722 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368722&action=review Thanks Brent for r+ this patch. >> Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp:131 >> + // be domains or IP addresses. https://url.spec.whatwg.org/#url-representation > > I think it might be simpler to just say: "The effective domain may be represented in various manners, such as a domain or an ip address. Only the domain format of host is permitted in WebAuthN. Fixed. >> Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp:198 >> + // be a domain or an IP address. https://url.spec.whatwg.org/#url-representation > > Ditto: I think it might be simpler to just say: "The effective domain may be represented in various manners, such as a domain or an ip address. Only the domain format of host is permitted in WebAuthN. Fixed.

Jiewen Tan

Comment 4 2019-05-01 18:40:46 PDT

Created attachment 368748 [details] Patch for landing

EWS Watchlist

Comment 5 2019-05-01 18:44:38 PDT

Comment on attachment 368722 [details] Patch Attachment 368722 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12056568 New failing tests: imported/w3c/web-platform-tests/xhr/event-upload-progress.htm

EWS Watchlist

Comment 6 2019-05-01 18:44:40 PDT

Created attachment 368749 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.4

Jiewen Tan

Comment 7 2019-05-01 18:50:13 PDT

(In reply to Build Bot from comment #5) > Comment on attachment 368722 [details] > Patch > > Attachment 368722 [details] did not pass ios-sim-ews (ios-simulator-wk2): > Output: https://webkit-queues.webkit.org/results/12056568 > > New failing tests: > imported/w3c/web-platform-tests/xhr/event-upload-progress.htm The test failure is completely unrelated. Not able to reproduce locally.

WebKit Commit Bot

Comment 8 2019-05-01 19:20:57 PDT

Comment on attachment 368748 [details] Patch for landing Clearing flags on attachment: 368748 Committed r244863: <https://trac.webkit.org/changeset/244863>

Radar WebKit Bug Importer

Comment 9 2019-05-02 15:36:04 PDT

<rdar://problem/50424889>

Note You need to log in before you can comment on or make changes to this bug.