| Summary: | [WebAuthN] Adopt SecurityOrigin::isMatchingRegistrableDomainSuffix() | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jiewen Tan <jiewen_tan> | ||||||||
| Component: | WebCore Misc. | Assignee: | Jiewen Tan <jiewen_tan> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | bfulgham, commit-queue, ews-watchlist, jiewen_tan | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 181943 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Jiewen Tan
2019-05-01 15:23:03 PDT
Created attachment 368722 [details]
Patch
Comment on attachment 368722 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368722&action=review Looks good! I would adjust the comments slightly, but no further review is needed. > Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp:131 > + // be domains or IP addresses. https://url.spec.whatwg.org/#url-representation I think it might be simpler to just say: "The effective domain may be represented in various manners, such as a domain or an ip address. Only the domain format of host is permitted in WebAuthN. > Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp:198 > + // be a domain or an IP address. https://url.spec.whatwg.org/#url-representation Ditto: I think it might be simpler to just say: "The effective domain may be represented in various manners, such as a domain or an ip address. Only the domain format of host is permitted in WebAuthN. Comment on attachment 368722 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368722&action=review Thanks Brent for r+ this patch. >> Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp:131 >> + // be domains or IP addresses. https://url.spec.whatwg.org/#url-representation > > I think it might be simpler to just say: "The effective domain may be represented in various manners, such as a domain or an ip address. Only the domain format of host is permitted in WebAuthN. Fixed. >> Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp:198 >> + // be a domain or an IP address. https://url.spec.whatwg.org/#url-representation > > Ditto: I think it might be simpler to just say: "The effective domain may be represented in various manners, such as a domain or an ip address. Only the domain format of host is permitted in WebAuthN. Fixed. Created attachment 368748 [details]
Patch for landing
Comment on attachment 368722 [details] Patch Attachment 368722 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12056568 New failing tests: imported/w3c/web-platform-tests/xhr/event-upload-progress.htm Created attachment 368749 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.4
(In reply to Build Bot from comment #5) > Comment on attachment 368722 [details] > Patch > > Attachment 368722 [details] did not pass ios-sim-ews (ios-simulator-wk2): > Output: https://webkit-queues.webkit.org/results/12056568 > > New failing tests: > imported/w3c/web-platform-tests/xhr/event-upload-progress.htm The test failure is completely unrelated. Not able to reproduce locally. Comment on attachment 368748 [details] Patch for landing Clearing flags on attachment: 368748 Committed r244863: <https://trac.webkit.org/changeset/244863> |