| Summary: | Pass KeyboardEvent by reference in more places | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||||||||
| Component: | WebKit Misc. | Assignee: | Daniel Bates <dbates> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | darin, ews-watchlist, thorton, webkit-bug-importer, wenson_hsieh | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Local Build | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | All | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Daniel Bates
2019-05-01 15:04:45 PDT
Created attachment 368720 [details]
Patch
It is so tempting to do more KeyboardEvent* to KeyboardEvent& changes, but the full transitive closure is getting kinda big. Here's a patch towards fixing everything! Comment on attachment 368720 [details]
Patch
r=mews
Created attachment 368787 [details]
Patch
Comment on attachment 368787 [details] Patch Attachment 368787 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12064541 New failing tests: svg/repaint/add-background-property-on-root.html Created attachment 368816 [details]
Archive of layout-test-results from ews211 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews211 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Created attachment 369010 [details]
To land
Committed r244932: <https://trac.webkit.org/changeset/244932> |