Bug 197480

Summary: Pass KeyboardEvent by reference in more places
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebKit Misc.Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ews-watchlist, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from ews211 for win-future
none
To land none

Daniel Bates
Reported 2019-05-01 15:04:45 PDT
Pass KeyboardEvent by reference in more places
Attachments
Patch (26.98 KB, patch)
2019-05-01 15:21 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (28.08 KB, patch)
2019-05-02 11:07 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews211 for win-future (14.10 MB, application/zip)
2019-05-02 13:50 PDT, EWS Watchlist 		no flags
Details
To land (28.20 KB, patch)
2019-05-03 16:03 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2019-05-01 15:21:29 PDT
Created attachment 368720 [details] Patch
Daniel Bates
Comment 2 2019-05-01 15:22:54 PDT
It is so tempting to do more KeyboardEvent* to KeyboardEvent& changes, but the full transitive closure is getting kinda big. Here's a patch towards fixing everything!
Wenson Hsieh
Comment 3 2019-05-01 15:25:35 PDT
Comment on attachment 368720 [details] Patch r=mews
Daniel Bates
Comment 4 2019-05-02 11:07:33 PDT
Created attachment 368787 [details] Patch
EWS Watchlist
Comment 5 2019-05-02 13:50:27 PDT
Comment on attachment 368787 [details] Patch Attachment 368787 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12064541 New failing tests: svg/repaint/add-background-property-on-root.html
EWS Watchlist
Comment 6 2019-05-02 13:50:29 PDT
Created attachment 368816 [details] Archive of layout-test-results from ews211 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews211 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Daniel Bates
Comment 7 2019-05-03 16:03:00 PDT
Created attachment 369010 [details] To land
Daniel Bates
Comment 8 2019-05-03 16:04:15 PDT
Committed r244932: <https://trac.webkit.org/changeset/244932>
Radar WebKit Bug Importer
Comment 9 2019-05-03 16:06:47 PDT
<rdar://problem/50460850>
Note You need to log in before you can comment on or make changes to this bug.