| Summary: | Add back hasNullReferences() assert in Document::updateIsPlayingMedia | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||
| Component: | Media | Assignee: | youenn fablet <youennf> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, darin, eric.carlson, jer.noble | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
youenn fablet
2019-05-01 14:13:35 PDT
Created attachment 368727 [details]
Patch
Comment on attachment 368727 [details] Patch Clearing flags on attachment: 368727 Committed r244860: <https://trac.webkit.org/changeset/244860> All reviewed patches have been landed. Closing bug. Comment on attachment 368727 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368727&action=review > Source/WebCore/Modules/webaudio/AudioContext.cpp:1069 > ScriptExecutionContext* AudioContext::scriptExecutionContext() const > { > - return m_isStopScheduled ? 0 : ActiveDOMObject::scriptExecutionContext(); > + return ActiveDOMObject::scriptExecutionContext(); > } Could we come back and just remove this override later? (In reply to Darin Adler from comment #4) > Comment on attachment 368727 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=368727&action=review > > > Source/WebCore/Modules/webaudio/AudioContext.cpp:1069 > > ScriptExecutionContext* AudioContext::scriptExecutionContext() const > > { > > - return m_isStopScheduled ? 0 : ActiveDOMObject::scriptExecutionContext(); > > + return ActiveDOMObject::scriptExecutionContext(); > > } > > Could we come back and just remove this override later? Could you clarify your suggestion? This override is currently needed as AudioContext is an EventTarget. Comment on attachment 368727 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368727&action=review >>> Source/WebCore/Modules/webaudio/AudioContext.cpp:1069 >>> } >> >> Could we come back and just remove this override later? > > Could you clarify your suggestion? > This override is currently needed as AudioContext is an EventTarget. OK, then we can’t remove it. |