| Summary: | Bug for testing EWS | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||||||||||||||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||||||||||||||||
| Status: | REOPENED --- | ||||||||||||||||||||
| Severity: | Normal | CC: | aakash_jain, ews-watchlist, glenn | ||||||||||||||||||
| Priority: | P2 | ||||||||||||||||||||
| Version: | Other | ||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
|
Description
Aakash Jain
2019-05-01 10:55:52 PDT
Created attachment 368685 [details]
Proposed patch
Attachment 368685 [details] did not pass style-queue:
ERROR: Source/WTF/wtf/CheckedArithmetic.h:395: This { should be at the end of the previous line [whitespace/braces] [4]
ERROR: Source/WTF/wtf/CheckedArithmetic.h:463: This { should be at the end of the previous line [whitespace/braces] [4]
ERROR: Source/WTF/wtf/CheckedArithmetic.h:471: This { should be at the end of the previous line [whitespace/braces] [4]
ERROR: Source/WTF/wtf/CheckedArithmetic.h:1002: Missing spaces around | [whitespace/operators] [3]
ERROR: Source/WTF/wtf/CheckedArithmetic.h:1040: Missing spaces around | [whitespace/operators] [3]
ERROR: Source/WTF/wtf/CheckedArithmetic.h:1060: Missing spaces around | [whitespace/operators] [3]
ERROR: Source/WTF/wtf/CheckedArithmetic.h:1123: This { should be at the end of the previous line [whitespace/braces] [4]
Total errors found: 7 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 368685 [details] Proposed patch Attachment 368685 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12053255 Number of test failures exceeded the failure limit. Created attachment 368701 [details]
Archive of layout-test-results from ews101 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 368735 [details]
Proposed patch
. Created attachment 442150 [details]
[fast-cq] Patch for landing
Created attachment 442256 [details]
[fast-cq] Patch for landing
ChangeLog entry in Tools/ChangeLog contains OOPS!. Created attachment 450231 [details]
Patch for testing
Created attachment 450260 [details]
Patch for testing
Created attachment 450424 [details]
Patch for testing
Pull request: https://github.com/WebKit/WebKit/pull/933 Pull request: https://github.com/WebKit/WebKit/pull/10892 |