Bug 197467

Summary:

Bug for testing EWS

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

REOPENED ---

Severity:

Normal

CC:

aakash_jain, ews-watchlist, glenn

Priority:

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	none
Archive of layout-test-results from ews101 for mac-highsierra	none
Proposed patch	none
[fast-cq] Patch for landing	none
[fast-cq] Patch for landing	ews-feeder: commit-queue-
Patch for testing	none
Patch for testing	none
Patch for testing	none

Description Aakash Jain 2019-05-01 10:55:52 PDT

Fixing few flaky API tests.

Comment 1 Aakash Jain 2019-05-01 11:03:12 PDT

Created attachment 368685 [details]
Proposed patch

Comment 2 EWS Watchlist 2019-05-01 12:42:55 PDT Comment hidden (obsolete)

Attachment 368685 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/CheckedArithmetic.h:395:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WTF/wtf/CheckedArithmetic.h:463:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WTF/wtf/CheckedArithmetic.h:471:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WTF/wtf/CheckedArithmetic.h:1002:  Missing spaces around |  [whitespace/operators] [3]
ERROR: Source/WTF/wtf/CheckedArithmetic.h:1040:  Missing spaces around |  [whitespace/operators] [3]
ERROR: Source/WTF/wtf/CheckedArithmetic.h:1060:  Missing spaces around |  [whitespace/operators] [3]
ERROR: Source/WTF/wtf/CheckedArithmetic.h:1123:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 7 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 EWS Watchlist 2019-05-01 13:44:14 PDT Comment hidden (obsolete)

Comment on attachment 368685 [details]
Proposed patch

Attachment 368685 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/12053255

Number of test failures exceeded the failure limit.

Comment 4 EWS Watchlist 2019-05-01 13:44:16 PDT Comment hidden (obsolete)

Created attachment 368701 [details]
Archive of layout-test-results from ews101 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-highsierra  Platform: Mac OS X 10.13.6

Comment 5 Aakash Jain 2019-05-01 16:53:11 PDT Comment hidden (obsolete)

Created attachment 368735 [details]
Proposed patch

Comment 6 Aakash Jain 2021-10-21 17:19:38 PDT Comment hidden (obsolete)

Comment 7 Aakash Jain 2021-10-22 04:23:04 PDT Comment hidden (obsolete)

Created attachment 442150 [details]
[fast-cq] Patch for landing

Comment 8 Aakash Jain 2021-10-23 05:04:16 PDT Comment hidden (obsolete)

Created attachment 442256 [details]
[fast-cq] Patch for landing

Comment 9 EWS 2021-10-23 05:05:04 PDT Comment hidden (obsolete)

ChangeLog entry in Tools/ChangeLog contains OOPS!.

Comment 10 Aakash Jain 2022-01-28 06:39:02 PST Comment hidden (obsolete)

Created attachment 450231 [details]
Patch for testing

Comment 11 Aakash Jain 2022-01-28 11:10:39 PST

Created attachment 450260 [details]
Patch for testing

Comment 12 Aakash Jain 2022-01-31 11:35:28 PST

Created attachment 450424 [details]
Patch for testing

Comment 13 Aakash Jain 2022-05-23 13:10:40 PDT

Pull request: https://github.com/WebKit/WebKit/pull/933

Comment 14 Aakash Jain 2023-03-01 13:20:26 PST

Pull request: https://github.com/WebKit/WebKit/pull/10892