Bug 197437

Summary: Add memory-limited skipping to some tests generating very large strings
Product: WebKit Reporter: Stephan Szabo <stephan.szabo>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, lforschler, mark.lam, ross.kirsling, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Stephan Szabo
Reported 2019-04-30 13:35:13 PDT
These three tests showed up as failing on PlayStation due to failing allocations, they each seem to try to make a 1 gig or larger string with padEnd or repeat, so seem like they should also fail in other highly memory limited environments. Some other tests doing similar things (such as stress/string-overflow-createError.js) have been marked skip if $memoryLimited.
Attachments
Patch (1.88 KB, patch)
2019-04-30 13:37 PDT, Stephan Szabo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Stephan Szabo
Comment 1 2019-04-30 13:37:44 PDT
Created attachment 368603 [details] Patch Add // @skip if $memoryLimited for stress/StringObject-define-length-getter-rope-string-oom.js stress/create-error-out-of-memory-rope-string.js stress/string-16bit-repeat-overflow.js
Ross Kirsling
Comment 2 2019-04-30 15:40:26 PDT
Comment on attachment 368603 [details] Patch Looking through other stress tests with values like 2147483644, it certainly appears that this trio was simply overlooked.
WebKit Commit Bot
Comment 3 2019-05-01 10:42:57 PDT
Comment on attachment 368603 [details] Patch Clearing flags on attachment: 368603 Committed r244832: <https://trac.webkit.org/changeset/244832>
WebKit Commit Bot
Comment 4 2019-05-01 10:42:58 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2019-05-01 10:43:16 PDT
<rdar://problem/50374075>
Note You need to log in before you can comment on or make changes to this bug.